390226 - [Trunk] Lightning breaks Thunderbird view layout

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[torindel]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.5) Gecko/20070720 Firefox/2.0.0.5
Build Identifier: TRUNK: Mon Jul 30 12:58:08 CEST 2007 [Thunderbird: version 3.0a1pre (2007073023) / Lightning: version 0.6a1 (2007073023)]

Without lightning thunderbird looks normal, after loading its layout brakes
Details in screen-shoot :)
Linux localhost 2.6.22-gentoo-r1 #1 SMP PREEMPT Sat Jul 28 19:35:15 CEST 2007 x86_64 AMD Turion(tm) 64 X2 Mobile Technology TL-50 AuthenticAMD GNU/Linux
gcc (GCC) 4.2.0 (Gentoo 4.2.0)
cairo-gtk2 toolkit

Reproducible: Always

Steps to Reproduce:
1.Load Lightning plugin
Actual Results:  
See screenshot

Expected Results:  
Look at normal version of lightning

Comment 1

[torindel]

i686 nightly build looks ok [ftp://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/nightly/latest-trunk/thunderbird-3.0a1pre.en-US.linux-i686.tar.bz2 (20070709) + ftp://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/nightly/latest-trunk/linux-xpi/lightning.xpi (20070730)]

Comment 2

[Martin Schröder [:mschroeder]]

Maybe the changes from bug 389730 are the cause of this bug.

Comment 3

[torindel]

Layout bug appeared between 2007-07-28-03 nightly build (last ok) and 2007-07-29-03 of thunderbird (tested with 20070730 lightning)
Another thing i noticed is out of place calendar widget which disappears after clicking anywhere: http://img252.imageshack.us/img252/1323/51466679at6.png

Comment 4

[torindel]

mschroeder was right https://bugzilla.mozilla.org/show_bug.cgi?id=389730 was the case
(thunderbird trunk with it removed + lightning trunk works ok)

Comment 5

[torindel]

Attachment: Patch for lightning to be compatible with trunk thunderbird (bug 389730)

Comment 6

[torindel]

Looks fixed ;]

Comment 8

[Daniel Boelzle [:dbo]]

Comment on attachment 274795 [details] [diff] [review]
Patch for lightning to be compatible with trunk thunderbird (bug 389730)

>--- mozilla/calendar/base/content/today-pane.xul~	2007-07-30 >-<box id="mailContent">
>+<box id="messengerBox">
Please use preprocessor #ifdef MOZILLA_1_8_BRANCH, so we could keep trunk and branch in sync.

>--- mozilla/calendar/lightning/content/messenger-overlay-sidebar.xul~	>-<hbox id="mailContent" flex="1">
>+<box id="messengerBox" orient="horizontal" flex="1" minheight="100" heigh="100" persist="height">
Apart from misspelling height, please remove those properties; ought not be necessary. Please use only a different id, i.e.

#ifdef MOZILLA_1_8_BRANCH
<hbox id="mailContent" flex="1">
#else
<hbox id="messengerBox" flex="1">
#endif

r- for now.

Comment 9

[torindel]

Attachment: Lightning thunderbird-trunk-layout compatibility patch

Comment 10

[Daniel Boelzle [:dbo]]

Comment on attachment 275139 [details] [diff] [review]
Lightning thunderbird-trunk-layout compatibility patch

r=dbo; thanks for the patch!

Comment 11

[Daniel Boelzle [:dbo]]

Checked in on HEAD and MOZILLA_1_8_BRANCH.