389730 - Port seamonkey's dynamic 3-pane configuration code to Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

The code Ian and Neil wrote to do the dynamic 3-pane generation in seamonkey is better than the original code we wrote for Thunderbird.

Specifically:

* It uses one less box
* The JS for dynamically changing the layout is a lot tighter

I've got a patch coming up that does this.

Comment 1

[Scott MacGregor]

Attachment: the fix

This should do the trick based on looking at seamonkey's messenger.xul and related files. 

I tested all 3 layout configurations. And I tested opening a message in a stand alone tab from all 3 layout configurations.

Note: opening a message tab from the vertical layout doesn't work, and that's unrelated to this bug. See Bug 389735.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 274059 [details] [diff] [review]
the fix

Looks good to me, r=mkmelin

Comment 3

[Tuukka Tolvanen (sp3000)]

+    <box id="messengerBox" orient="horizontal" flex="1" minheight="100" heigh="100" persist="height">

heigh?

Comment 4

[Scott MacGregor]

I just fixed the typo, hopefully that fixes it.

Comment 5

[Tuukka Tolvanen (sp3000)]

     <!-- when we move to the alternate 3-pane, mailContentWrapper gets toggled to a vertical orientation -->
-    <box id="mailContentWrapper" orient="horizontal" flex="1">

that comment is stale as there is no mailContentWrapper anymore

Comment 6

[Wayne Woods]

Bug 390585 has a messagepane height issue that most likely results from this.

Comment 7

[Wayne Woods]

Guess I didn't search well enough. It's a dupe of bug 390177. Sorry.

Comment 8

[alta88]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007081004 Thunderbird/3.0a1pre ID:2007081004

Tb immediately crashes upon changing the layout view, each time.  A couple of crash reports have been sent.