390293 - Event/task dialog does nothing upon "Save and close" when Thunderbird main window is closed

Status: NEW

(Calendar :: Dialogs, defect)

Description

[Raymond]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070725 Firefox/2.0.0.6
Build Identifier: lightning 0.7pre (build 2007073003)

If you have the "new event" dialog open and press "Save and close" but Thunderbird is exited, there appears a progress-bar in the status-bar of the dialog but nothing happens

Reproducible: Always

Steps to Reproduce:
1. Open the "new event" dialog
2. Exit Thunderbird
3. Fill out the details
4. push "Save and close"
Actual Results:  
A progress-bar appears in the status-bar of the dialog but nothing happens.


Expected Results:  
The event is saved and the dialog closed.

I was using thunderbird 2.0.0.5 (20070716)

Comment 1

[Stefan Sitter [:ssitter]]

I can confirm. Console shows:

  Error: doTransaction is not defined
  Source File: chrome://calendar/content/calendar-item-editing.js
  Line: 59

Comment 2

[Michael Büttner (no reviews TFN)]

This happens because the calendar code is loaded into the xul-context of Thunderbird's window. If the window will be closed all relevant parts of the calendar engine will be unloaded as well (e.g. code from calendar-item-editing.js). That's why we fail later if the event dialog tries to call back to the code that opened the window. One particular solution I could imagine would to make all the calendar code contained in a service.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Oops, sorry, my bad, returning to the right component, awfully sorry about stomping your target milestone, please send hatemail to this address :(

Comment 6

[PM]

Under  Lightning/1.0b3pre, Lightning ask for saving and do the job when thunderbird is closed from the main windows (File->Exit). 

Looking at the code for ln 0.7:
-------------------------------
File calendar-event-dialog.js
window.tryToClose = function calItemDialogAttemptClose() {
...
promptService.confirm
}

Code in ln 1.0b3pre:
--------------------
window.tryToClose = onCancel;
onCancel:
if (!gConfirmCancel || (gConfirmCancel && onCommandCancel())) {

onCommandCancel:
promptService.confirmEx
case 0: // Save
  onCommandSave(true);

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

This could be fixed together with bug 373251, please see my comments there.

Philippe, this bug is not about File > Exit, but rather using the following steps:


1. Open an event dialog
2. Close the main window using the [X] on the window.
-- Now you have Thunderbird still running, but the main window is closed
3. Save and Close in the event dialog
4. Get error messages

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Taking off the blocking list, I see this as part of bug 373251, which is also on the blocking list.

Comment 9

[Patrick Seiter]

Why was Sunbird taken off of the summary? This bug is still present in Sunbird last I checked.

I can see two solutions for Sunbird: A) Sunbird is split into a service and a UI wherein the service would sit in the system tray as the Sunbird icon and double-clicking it would open the UI, or B) prevent the main window from closing if there are any child windows open.

I prefer the former.

Comment 10

[Stefan Sitter [:ssitter]]

Sunbird development was stopped in 2010. Don't expect any new Sunbird releases or bug fixes.

Comment 11

[Patrick Seiter]

Thank you for telling me. I knew development was halted, but I only just now read the reasons why it was halted.