390401 - Tabsposé thumbnails don't preserve aspect ratio

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Stuart Morgan]

The tabsposé thumbs distort badly as the window is resized, but they are all also slightly distorted in the initial view (for the same reason; they use the aspect ratio of the tabspose view, which is taller than the pages due to the status bar and bookmark bar being removed). There are two options I can think of:
1) keep the same grid layout calculation, and have each thumbnail draw to the largest size of the correct aspect ratio that will fit within its view.
2) figure out the best layout and size for the current view shape/size, and update the grid accordingly.

Option 2) is nicer, but trickier. I think just from a standpoint of making ThumbnailView generically useful, having its draw routine do 1) is a good idea anyway, so let's start there and then we can do 2) afterward if we want to.

Comment 1

[Stuart Morgan]

Attachment: fix

Implements option 1 (we could do 2 as a follow-up enhancement, but since resizing in tabspose mode is likely to be rare it's probably not worth the trouble)

Comment 2

[Jeff Dlouhy]

Comment on attachment 318089 [details] [diff] [review]
fix

I like how this works for now. We can look into different ways of resizing and reordering down the road.

r=jeff

Comment 3

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 318089 [details] [diff] [review]
fix

sr=pink

Comment 4

[Stuart Morgan]

Landed on trunk.