Closed
Bug 390401
Opened 17 years ago
Closed 16 years ago
Tabsposé thumbnails don't preserve aspect ratio
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)
References
Details
Attachments
(1 file)
1.20 KB,
patch
|
Jeff.Dlouhy
:
review+
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
The tabsposé thumbs distort badly as the window is resized, but they are all also slightly distorted in the initial view (for the same reason; they use the aspect ratio of the tabspose view, which is taller than the pages due to the status bar and bookmark bar being removed). There are two options I can think of:
1) keep the same grid layout calculation, and have each thumbnail draw to the largest size of the correct aspect ratio that will fit within its view.
2) figure out the best layout and size for the current view shape/size, and update the grid accordingly.
Option 2) is nicer, but trickier. I think just from a standpoint of making ThumbnailView generically useful, having its draw routine do 1) is a good idea anyway, so let's start there and then we can do 2) afterward if we want to.
Blocks: 410866
Assignee | ||
Comment 1•16 years ago
|
||
Implements option 1 (we could do 2 as a follow-up enhancement, but since resizing in tabspose mode is likely to be rare it's probably not worth the trouble)
Assignee: Jeff.Dlouhy → stuart.morgan
Status: NEW → ASSIGNED
Attachment #318089 -
Flags: review?(Jeff.Dlouhy)
Comment 2•16 years ago
|
||
Comment on attachment 318089 [details] [diff] [review]
fix
I like how this works for now. We can look into different ways of resizing and reordering down the road.
r=jeff
Attachment #318089 -
Flags: review?(Jeff.Dlouhy) → review+
Assignee | ||
Updated•16 years ago
|
Attachment #318089 -
Flags: superreview?(mikepinkerton)
Comment 3•16 years ago
|
||
Comment on attachment 318089 [details] [diff] [review]
fix
sr=pink
Attachment #318089 -
Flags: superreview?(mikepinkerton) → superreview+
Assignee | ||
Comment 4•16 years ago
|
||
Landed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•