390495 - [Trunk] datepicker combo from calendar tab is expanded after starting thunderbird

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[torindel]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.5) Gecko/20070720 Firefox/2.0.0.5
Build Identifier: TRUNK

datepicker widget is shown after starting thunderbird (look at picture in url) and is positioned directly under datepicker combobox which is on calendar tab (this occurs in non-pre0.7 lightning)due change in thunderbird trunk between 2007-07-04 and 2007-07-05 

Reproducible: Always

Steps to Reproduce:
1.Start thunderbird with lightning installed

Comment 1

[torindel]

this *also* occurs in non-pre0.7 lightning (typo)

Comment 2

[Stefan Sitter [:ssitter]]

(In reply to comment #1)
> this *also* occurs in non-pre0.7 lightning (typo)

Instead of writing "non-pre0.7 lightning" please note the correct Lightning version and Build ID as shown in the Addon-Manager. Please also note the Thunderbird version and Build ID.

It seems that you filed the same issue just a few days ago with Bug 390226.

Comment 3

[torindel]

affect all minicalendar combo-boxes everywhere (e.g. in add new event window after opening dialog window we get couple of such auto expanded on create combo-boxes) (tested on calendar trunk nightly builds from last 2 months) due to change in thunderbird trunk older than 2007-07-05

Comment 4

[torindel]

Last good nightly build thunderbird version: version 3.0a1pre (2007070504)

Comment 5

[torindel]

this bug is caused by https://bugzilla.mozilla.org/show_bug.cgi?id=279703

Comment 6

[Stefan Sitter [:ssitter]]

Works for me using Lightning 0.6a1 (2007080105) with Thunderbird 3.0a1pre (2007080104) on Windows 2000. Datepicker behaves correctly.

Comment 7

[torindel]

tested windows build too and its ok, both my linux build and official nighly linux trunk is affected can someone test on mac?

Comment 8

[Stefan Sitter [:ssitter]]

Confirmed using Thunderbird 3.0a1pre (2007083103) + Lightning 0.6a1 (2007083103) on Ubuntu 7.10. The popup disappears as soon as you click somewhere in the Thunderbird UI.

Comment 9

[Stefan Sitter [:ssitter]]

Similar behavior in all dialogs that use the datepicker control.

Opening the Event dialog causes two datepicker popups (start/end) to be displayed immediately. Opening the task dialog causes three datepicker popups (begin/due/completed) to be displayed immediately. ...

Comment 10

[Christian Schmidt]

Attachment: Don't trigger monthchange upon initialization

The problems is that minimonth fires an onmonthchange upon initialization. This makes the datepicker think that the minimonth is already displayed and that it needs to apply the reshow hack.

minimonth.constructor() calls minimonth.refreshDisplay() that calls minimonth.showMonth() that always fires the event. This patch suppresses the event the first time showMonth() is called.

Comment 11

[Michael Büttner (no reviews TFN)]

Comment on attachment 290033 [details] [diff] [review]
Don't trigger monthchange upon initialization

> The problems is that minimonth fires an onmonthchange
> upon initialization. This makes the datepicker think
> that the minimonth is already displayed and that it
> needs to apply the reshow hack.
Thanks for figuring out...

>+    var monthChanged = this.mEditorDate && (this.mEditorDate != aDate);
Nice and clean patch, thanks again. r=mickey.

Comment 12

[Michael Büttner (no reviews TFN)]

patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 15

[Martin Schröder [:mschroeder]]

Setting milestone to 0.8 although it was a trunk only bug because the patch was checked in on HEAD and MOZILLA_1_8_BRANCH.