390560 - js1_6/Regress/regress-382509.js FAIL browser - NS_ERROR_ILLEGAL_VALUE

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bob Clary [:bc] (inactive)]

browser only, regressed after 2007073104 build.

  global.foo = eval;
  global.a   = 'global';
  expect = 'global indirect';
=>  actual = String(['a+" indirect"'].map(global.foo));

uncaught exception: [Exception... "Illegal value" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: http://test.mozilla.com/tests/mozilla.org/js/js1_6/Regress/regress-382509.js :: test :: line 61" data: no]

bug 389878 ?

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Moving to a better component and removing the accidentally-set security flag.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

I'd written this exact patch at some point, but must have decided I didn't need it for some (wrong) reason.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 274871 [details] [diff] [review]
Proposed fix

You might want to complete the first sentence in the comment, other than that r+sr=jst

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 274871 [details] [diff] [review]
Proposed fix

This allows someone to pull a function off of a XOW and call it with a different 'this' object. The patch only affects this case, and should be very safe.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.