390752 - prevent the user from dropping bookmarks in the middle of a selection

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P5)

Description

[(not reading, please use [e-mail] instead)]

prevent the user from dropping bookmarks in the middle of a selection

steps to reproduce:

1)  select 5 bookmarks in the bookmark manager
2)  attempt to drag and drop them into the middle of the selection

actual results:  I'm allowed to do this

expected results:  don't allow this (show the no drop indicator)

Comment 1

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 2

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.

Comment 3

[Marco Bonardo [:mak]]

This may require some experimentation on how to do it, but it should be feasible modifying the dragover event in the treeview https://searchfox.org/mozilla-central/rev/50c3cf7a3c931409b54efa009795b69c19383541/browser/components/places/content/places-tree.js#75

Comment 4

[James Teow [:jteow]]

Attachment: Bug 390752 - Disallow dropping selected bookmarks onto itself r=mak

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/490c7d03b22a
Disallow dropping selected bookmarks onto itself r=mak,mcheang

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/490c7d03b22a