391746 - cant create new address book - nsIAddressBook.newAddressBook [@ addressbook.js :: AbOnCreateNewAddressBook :: line 349]

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Wayne Mery (:wsmwk)]

version 3.0a1pre (2007081004)

Error: [Exception... "Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIAddressBook.newAddressBook]"  nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)"  location: "JS frame :: chrome://messenger/content/addressbook/addressbook.js :: AbOnCreateNewAddressBook :: line 349"  data: no]
Source File: chrome://messenger/content/addressbook/addressbook.js
Line: 349

Comment 1

[Mark Banner (:standard8)]

This WFM on Thunderbird nightly (linux) version 3.0a1pre (2007081003) and SeaMonkey and Thunderbird self-built versions.

How are you invoking it? via File -> New -> Address Book?

Comment 2

[Wayne Mery (:wsmwk)]

yes
happens also in safe mode.
and in a clean profile

Comment 3

[David :Bienvenu]

we end up in nsAbDirProperty::CreateNewDirectory instead of nsAbBSDirectory::CreateNewDirectory, even though the object is an nsAbSDirectory and the type signatures are the same. I'm going to do a clean rebuild.

Comment 4

[David :Bienvenu]

ok, I see the problem - the type signatures aren't exactly the same - fix upcoming.

Comment 5

[David :Bienvenu]

Attachment: proposed fix

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 276290 [details] [diff] [review]
proposed fix

I'm assuming you were asking me for review... (I've just changed my email address).

This is exactly the same patch as on bug 391047 that's also waiting Scott's review...

Comment 7

[David :Bienvenu]

ah, thx, Mark. I'll just land it.

Comment 8

[David :Bienvenu]

fixed