Closed
Bug 391994
Opened 17 years ago
Closed 17 years ago
[FIX]Building a <select> via DOM doesn't select the right options
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
12.53 KB,
patch
|
sicking
:
approval1.9+
|
Details | Diff | Splinter Review |
Tests and fix coming up. This is a regression from bug 315920.
|
Assignee | |
Comment 1•17 years ago
|
||
Attachment #276446 -
Flags: superreview?(jonas)
Attachment #276446 -
Flags: review?(jonas)
|
|
Assignee | |
Updated•17 years ago
|
Flags: blocking1.9?
Keywords: regression
Attachment #276446 -
Flags: superreview?(jonas)
Attachment #276446 -
Flags: superreview+
Attachment #276446 -
Flags: review?(jonas)
Attachment #276446 -
Flags: review+
|
|
Assignee | |
Comment 2•17 years ago
|
||
Comment on attachment 276446 [details] [diff] [review] Fix This is a fix for a regression that causes us to not properly mark options as selected in dynamically built <select>s. Risk is moderate, I think. I wrote a bunch of tests, and we pass them, but this is unfortunately somewhat fragile code...
Attachment #276446 -
Flags: approval1.9?
|
|
Assignee | |
Comment 3•17 years ago
|
||
Attachment #276446 -
Attachment is obsolete: true
Attachment #276557 -
Flags: approval1.9?
Attachment #276446 -
Flags: approval1.9?
Attachment #276557 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: blocking1.9? → in-testsuite+
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•17 years ago
|
||
This caused bug 395107.
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•