401554 - Setting defaultSelected on options can make multiple options selected

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, when opening the select, you see all options selected, while you only should see only one option selected (option 4, probably).

This regressed between 2007-08-20 and 2007-08-21:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-08-20+04&maxdate=2007-08-21+09&cvsroot=%2Fcvsroot
Because of bug 391994, I guess.

Now, defaultSelected didn't seem to work at all before that, it seems. So that's why it doesn't cause this layout issue, I guess.

As a sidenote, as a result, I would expect:
Result:
Option 1
Option 4

And after a reload:
Result:
Option 4
Option 4

This is a (small) problem on the united airlines websites where you can see two options selected when opening the Month combobox.

I guess there is also some relation to bug 395107 here.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Assigning to Boris since it's a regression from bug 391994.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Oops.  I forgot to resolve this.  The patch in bug 395107 fixes this bug (and I checked in a test for it as part of that patch).  Sorry for the waste of triage time.  :(

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Who cares, I'm just glad this is fixed :-)