392125 - Java plugin doesn't stay disabled on restart when disabled via plugin manager

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Tony Chung [:tchung]]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007081304 Minefield/3.0a8pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007081304 Minefield/3.0a8pre

I am unable to disable the java embedded plugin using the plugin manager.  I've "disabled" the component and restarted, but it still appears as enabled.  Also, the java applet in the URL example will be reset to enable after a browser restart.

Reproducible: Always

Steps to Reproduce:
1. install latest minefield
2. install JEP plugin
3. open Tools > Addons > plugins
4. Disable JEP, then restart browser
5. Go to URL testsite, and verify java applet still loads
6. go back to plugin manager, and verify JEP is still enabled after reboot.
Actual Results:  
Java applet still loads after disabling and restarting.

Expected Results:  
java applet should be disabled after restart.

Comment 1

[Steven Michaud [:smichaud] (Retired)]

I've confirmed this with today's nightly on both Mac OS X and Windows
XP -- so it's clearly not a bug in the Java Embedding Plugin.  (On
Windows XP I disabled all the "Java(TM) 2 Platform Standard Edition
5.0" plugins -- they were all enabled again after I restarted
Minefield.)

Disabling the Java Embedding Plugin via Tools : Addons : Plugins
_does_ work as long as you _don't_ restart Minefield.

I suppose Minefield is confused because previously the only way to
disable or enable Java was via Preferences : Enable Java.

Comment 2

[Robert Strong (they/them - no direct email)]

This is known... the preferred route is for a decision to be made in regards to bug 344638 before we can fix this.

Comment 3

[Michael Wu [:mwu]]

Moving.. fix belongs in backend plugins code

Comment 4

[Michael Wu [:mwu]]

Attachment: Special case Java plugins

This does two things:

1. Whether a plugin is a java plugin is now checked once at java tag initialization, as opposed to as needed.
2. Disabling java plugins now flips the java enable/disable pref first, which then causes the plugin host code to iterate through all java plugins and actually toggle their enabled/disabled state.

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 278164 [details] [diff] [review]
Special case Java plugins

- In nsPluginTag::nsPluginTag():

+      if (nsPluginHostImpl::IsJavaMIMEType(mMimeTypeArray[i]))
+        mIsJavaPlugin = PR_TRUE;

This is conditionally set to PR_TRUE here, but it's never defaulted to false anywhere in this constructor. This will lead to random plugins thinking they're java plugins.

r+sr=jst with that fixed.

Comment 6

[Michael Wu [:mwu]]

(In reply to comment #5)
> (From update of attachment 278164 [details] [diff] [review])
> - In nsPluginTag::nsPluginTag():
> 
> +      if (nsPluginHostImpl::IsJavaMIMEType(mMimeTypeArray[i]))
> +        mIsJavaPlugin = PR_TRUE;
> 
> This is conditionally set to PR_TRUE here, but it's never defaulted to false
> anywhere in this constructor. This will lead to random plugins thinking they're
> java plugins.
> 
Ick, I did it in the other constructor but not this one. Opps. Thanks.

Comment 9

[Michael Wu [:mwu]]

Attachment: Special case Java plugins, v2

Comment 10

[Michael Wu [:mwu]]

Attachment: Special case Java plugins, v2 (real patch)

Opps.. uploaded the wrong patch.

Comment 11

[Michael Wu [:mwu]]

Checking in modules/plugin/base/src/nsPluginHostImpl.cpp;
/cvsroot/mozilla/modules/plugin/base/src/nsPluginHostImpl.cpp,v  <--  nsPluginHostImpl.cpp
new revision: 1.589; previous revision: 1.588
done
Checking in modules/plugin/base/src/nsPluginHostImpl.h;
/cvsroot/mozilla/modules/plugin/base/src/nsPluginHostImpl.h,v  <--  nsPluginHostImpl.h
new revision: 1.109; previous revision: 1.108
done

Comment 12

[Tony Chung [:tchung]]

Added Litmus testcase: http://litmus.mozilla.org/show_test.cgi?id=4618

Comment 13

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007090504 Minefield/3.0a8pre.  JEP remains disabled now if selected.