392173 - Calendars should have a defined color by default

Status: RESOLVED WONTFIX

(Calendar :: Internal Components, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Currently, there is a hard coded default color for calendars, if the user doesn't select the color in the new calendar wizard. This isnt theme-friendly and might also cause some other problems, for example its impossible to return to this color. See bug 306244.

A possible solution would be to set the colorpicker in the new calendar wizard to a specific color, which would ideally be defined somewhere in the theme. 

See [1] for all references to this color.

[1] http://mxr.mozilla.org/seamonkey/search?string=a8c2e1&find=calendar

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 2

[Decathlon]

Comment on attachment 751500 [details] [diff] [review]
Fix - v1

Review of attachment 751500 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the late review.

The patch works fine so I give a r+.
Minor observations:

- It's a wanted behavior to change the color in the color picker with the name of the calendar but it's a bit odd to see the displayed color changing while the user types the calendar name in the textbox at the first assignment. Anyway it's not a problem for the usability.

- the default calendar "Home" is still without a color assigned and, when displayed in the calendar list, it gets the default color #a8c2e1 (that one inexistent in the color picker), but when you open the Edit Calendar dialog, the color showed in the color picker is the new one (#CCCCCC) assigned with the patch.

If it can be useful, I've added to your patch a line of code that assigns the color #CCCCCC for the "Home" calendar when it is being created so it would eliminate the last problem. Moreover I replaced all the references to #a8c2e1 with #CCCCCC. I don't know if there is something else to consider though.

Comment 3

[Decathlon]

Attachment: fix-v1 with addition mentioned in comment 2

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

(In reply to Decathlon from comment #2)
> Comment on attachment 751500 [details] [diff] [review]
> Fix - v1
> 
> Review of attachment 751500 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Sorry for the late review.
> 
> The patch works fine so I give a r+.
> Minor observations:
> 
> - It's a wanted behavior to change the color in the color picker with the
> name of the calendar but it's a bit odd to see the displayed color changing
> while the user types the calendar name in the textbox at the first
> assignment. Anyway it's not a problem for the usability.
I did this to make it a bit more obvious why the color is changing. If we'd wait for 500ms before changing the color, the user may think its a bug that the color has changed.

> If it can be useful, I've added to your patch a line of code that assigns
> the color #CCCCCC for the "Home" calendar when it is being created so it
> would eliminate the last problem. Moreover I replaced all the references to
> #a8c2e1 with #CCCCCC. I don't know if there is something else to consider
> though.
Looks find, thanks for updating that. I have no idea why I chose #CCC though, its a really ugly color. I'll see if I can come up with a different color.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Closing this bug in favor of the work in bug 1002597. We can now select any color.