392305 - XMLList is not defined

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bob Clary [:bc] (inactive)]

Bug 386265 caused XMLList is not defined errors in the browser only. You can run other XMLList tests from <http://test.bclary.com/tests/mozilla.org/js/menu>

Comment 1

[Bob Clary [:bc] (inactive)]

I'm not sure this is real anymore. I'm doing another build to check. ETA a few minutes.

Comment 2

[Bob Clary [:bc] (inactive)]

Igor, I can reproduce this with cvs builds but not with nightlies. I have to go out for a couple of hours, and I'll look into it more when I get back. If you want to mark it WFM, that is ok.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Oddly enough, cx->runtime->atomState.lazy.XMLListAtom seems to be an atom for cmd_selectAll when I am able to reproduce this locally.

Comment 4

[Igor Bukanov]

(In reply to comment #3)
> Oddly enough, cx->runtime->atomState.lazy.XMLListAtom seems to be an atom for
> cmd_selectAll when I am able to reproduce this locally.
> 

When I added the following code tp the bottom of StdNameToAtom in jsapi.c before the function return,

#if 1
    if (atom && stdn->name) {
        char buf[100];
        js_PutEscapedString(buf, sizeof(buf), ATOM_TO_STRING(atom), 0);
        if (strcmp(buf, stdn->name) != 0) 
            fprintf(stderr, "wanted=%s\ngot=%s\nhadAtom=%d\n", stdn->name, buf, hadAtom);
        JS_ASSERT(strcmp(buf, stdn->name) == 0);
    }
#endif

I got the assert triggered once right after the build, but only once.

Comment 5

[Igor Bukanov]

Attachment: fix v1

As a leftover from one of early versions of the patch I removed ATOM_PINNED from StdNameToAtom.

Comment 6

[Brendan Eich [:brendan]]

Comment on attachment 276815 [details] [diff] [review]
fix v1

Oops, I should have seen that.

This explains all the follow-on bugs.

/be

Comment 7

[Igor Bukanov]

I checked in the patch from comment 5 to the trunk:

Checking in jsapi.c;
/cvsroot/mozilla/js/src/jsapi.c,v  <--  jsapi.c
new revision: 3.349; previous revision: 3.348
done

Comment 10

[Bob Clary [:bc] (inactive)]

verified fixed 1.9.0 linux/mac*/windows.