392536 - Search query parameters not dynamically updated/kicked off when file state changes.

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Build ID: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre)
Gecko/2007081604 Minefield/3.0a8pre

Summary: Search query parameters not dynamically updated/kicked off when file state changes.

Steps to Reproduce:

1. Download a large-enough file (or be on a slow-enough connection), so you've got time to do this.
2. Enter a small substring of the filename, like "mul" for "Mulholland_Drive.pdf" (for example) in the "Search ..." textfield.
3. Leave the "mul" substring in the textfield, and wait for the download to complete.  Note that it appears in the "Search Results" view.
4. When the download completes, check the "Search Results" view.

Actual Results:

Once "Mulholland_Drive.pdf" completes--and moves from "Active" to "Completed", it disappears from the "Search Results" view until you backspace or add additional text, such as "Mull"

Expected Results:

I'd expect that even though the file has since completed its download, it should remain in the "Search Results" view.

Comment 1

[Shawn Wilsher :sdwilsh]

I'm not sure I want this to work as popping up something in the search results could be counter intuitive.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #1)
> I'm not sure I want this to work as popping up something in the search results
> could be counter intuitive.

It doesn't appear to the user that way (I can see both cases, though), so whichever is less complicated/jarring.  The net effect is that the user actually watches their search results get removed because it happens to change its state to "Complete", which I think is also bad. 

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

There's another case, and that is:

1. Download something large
2. Search for it
3. Cancel it

At this point (3), it disappears from the UI; if you adjust the search query by deleting a letter, it reappears.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008022804 Minefield/3.0b4pre

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008022804 Minefield/3.0b4pre

-and-

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008022806 Minefield/3.0b4pre

Litmus testcases coming a bit later...

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

in-litmus+:

1) https://litmus.mozilla.org/show_test.cgi?id=5206 (comment 0)
2) https://litmus.mozilla.org/show_test.cgi?id=5207 (comment 3)