Closed Bug 392672 Opened 17 years ago Closed 12 years ago

four white pixel around progress bar in download manager

Categories

(Core :: Widget: Win32, defect)

Product:
Core
Component:
Widget: Win32
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla22

People

(Reporter: moco, Assigned: jimm)

References

Details

Attachments

(2 files, 5 obsolete files)

screen shot
16.86 KB, image/png
Details
progress corners
3.76 KB, patch
bbondy
: review+
Details | Diff | Splinter Review
Attached image screen shot —
four white pixel around progress bar in download manager Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007081505 Minefield/3.0a8pre I've attached a screen shot
Hrm, we just use native widgets, so is this a bug there?
and by native, I mean we just use the default xbl binding (which I assume is native)
Yeah, this drives my OCD crazy.
It may just be OCD on my side too but I think it looks unpolished... any hope to get this fixed for FF3?
Product: Firefox → Toolkit
Component: Download Manager → Widget: Win32
Product: Toolkit → Core
QA Contact: download.manager → win32
Assignee: nobody → netzen
Assignee: netzen → nobody
Depends on: 726144
Attached patch preserve corners (obsolete) — — Splinter Review
Assignee: nobody → jmathies
Attached patch preserve corners (obsolete) — — Splinter Review
added support for vertical meters
Attachment #597932 - Attachment is obsolete: true
Attached patch preserve corners (obsolete) — — Splinter Review
turns out ms addressed this in vista with a new progress track that's transparent.
Attachment #598102 - Attachment is obsolete: true
Attached patch preserve corners (obsolete) — — Splinter Review
Turns out PP_TRANSPARENTBAR isn't defined on any of the current release platforms. So I'm using the corner trick for every os.
Attachment #598220 - Attachment is obsolete: true
Attached patch preserve corners v.1 (obsolete) — — Splinter Review
Note, these are built on top of the patches in bug 658885 and the fadable widgets patches. I can post a complete rollup if needed.
Attachment #599101 - Attachment is obsolete: true
Attachment #600802 - Flags: review?(neil)
Comment on attachment 600802 [details] [diff] [review] preserve corners v.1 Sorry, I don't have Aero.
Attachment #600802 - Flags: review?(neil)
(In reply to neil@parkwaycc.co.uk from comment #12) > Comment on attachment 600802 [details] [diff] [review] > preserve corners v.1 > > Sorry, I don't have Aero. This applies to xp as well. See https://bug392672.bugzilla.mozilla.org/attachment.cgi?id=277173
Attached patch progress corners — — Splinter Review
This fixes the corner problem by grabbing the starting corner pixel color if there is one, and painting it on all four corners after DrawThemeBackground finishes painting the corners white.
Attachment #600802 - Attachment is obsolete: true
Attachment #614566 - Flags: review?(netzen)
Comment on attachment 614566 [details] [diff] [review] progress corners Review of attachment 614566 [details] [diff] [review]: ----------------------------------------------------------------- The pixels that touch the 4 corners anti-alias to white but I think this will be an improvement and good enough.
Attachment #614566 - Flags: review?(netzen) → review+
No longer depends on: 726144
Blocks: 726144
https://hg.mozilla.org/mozilla-central/rev/4ab31c69d246
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: