658885 - XUL progress meters are (still) clipped incorrectly

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Comment 1

[Jim Mathies [:jimm]]

Attachment: downloads

Comment 2

[Jim Mathies [:jimm]]

Attachment: html version

Strange, the html version looks ok.

Comment 3

[Jim Mathies [:jimm]]

Attachment: progress tags

Comment 4

[...]

Attachment: html version not entirely accurate also

Comment 5

[Mounir Lamouri (:mounir)]

So, for some reason, the chunk is painted with an offset of two pixels. One is expected: it's because the progressbar widget has a one pixel border but I can't find why there is a second pixel involved here. (both margins and borders size are ok)

Comment 7

[Chris B.]

(In reply to comment #5)
> So, for some reason, the chunk is painted with an offset of two pixels. One
> is expected: it's because the progressbar widget has a one pixel border but
> I can't find why there is a second pixel involved here. (both margins and
> borders size are ok)

Then just change the code to use one more pixel!  If that doesn't work, then revert the code back and try something else.

Comment 8

[Samuel Coleman]

Just noticed this after updating to Firefox 6.0.

Is this perhaps related to bug 392672?

Comment 9

[Mounir Lamouri (:mounir)]

(In reply to Samuel Coleman from comment #8)
> Just noticed this after updating to Firefox 6.0.
> 
> Is this perhaps related to bug 392672?

Unfortunately not.

Comment 11

[Jim Mathies [:jimm]]

This is pretty easy to fix through some tweaks to widgetRect/clipRect down in the theme code.

Comment 12

[Jim Mathies [:jimm]]

Attachment: adjust rect

Comment 13

[Jim Mathies [:jimm]]

Attachment: adjust rect

added vertical meter support

Comment 14

[Jim Mathies [:jimm]]

Attachment: fix

Comment 15

[Jim Mathies [:jimm]]

Attachment: fix v.1

cleanup and testing on xp.

Comment 16

[Jim Mathies [:jimm]]

Comment on attachment 599100 [details] [diff] [review]
fix v.1

I've rolled these changes in with bug 658829.