392822 - Package plugin.xpt for non-installer builds, too

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Bug 339056 -> bug 391820 -> bug 391886 - to have the add-ons manager work, we need plugin.xpt, and while bug 391886 made us ship it for (Windows) installer builds, for zip/tar.bz2/dmg builds, we're taking it back out during packaging.

No idea what the plugin crashes that the checkin comment mentions were, but if they come back, I guess we'll just have to deal with them (and, we've been shipping it to most of our trunk testers for more than a week now, without any new plugin crashes filed that I've seen).

Comment 1

[Phil Ringnalda (:philor)]

mail/installer/Makefile.in 1.22

Comment 2

[Joe Sabash [:JoeS1]]

(In reply to comment #0)
> Created an attachment (id=277327) [details]
> Fix v.1
> 
> Bug 339056 -> bug 391820 -> bug 391886 - to have the add-ons manager work, we
> need plugin.xpt, and while bug 391886 made us ship it for (Windows) installer
> builds, for zip/tar.bz2/dmg builds, we're taking it back out during packaging.

I probably don't know the build system well enough to comment, but I use zip builds and plugin.xpt was added in a partial update.
 
> No idea what the plugin crashes that the checkin comment mentions were, but if
> they come back, I guess we'll just have to deal with them (and, we've been
> shipping it to most of our trunk testers for more than a week now, without any
> new plugin crashes filed that I've seen).
> 
I followed those bugs closely, and didn't see any refs to crashing due to plugins. However, having used plugins in TB trunk for years, I would be glad to provide you with some.

Comment 3

[timeless]

i'm pretty sure it was java. this is the second time i've read this bug mail thread that i haven't had the energy to search for the references.