393104 - [Proto] Event dialog: Documents dialog uses hardcoded strings

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Michael Wolf]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; hsb-DE; rv:1.8.1.5) Gecko/20070716 SeaMonkey/1.1.3
Build Identifier: 2007082106

The small dialog for the documents button in the New Event dialog is hardcoded, it isn'localizable. The hardcode is in file sun-calendar-event-dialog in function editURL (lines 1619-1640)

Reproducible: Always

Steps to Reproduce:
1. Choose any calendar view
2. Do right click
3. Click on new event
4. Click on button Documents


Actual Results:  
Documents dialog is after localization in English

Expected Results:  
Documents dialog should be in the new locale language

Comment 1

[Michael Wolf]

The issue could be in Sunbird too, but I couldn't test it in Sunbird.

Comment 2

[Stefan Sitter [:ssitter]]

Confirmed. Hard coded strings: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/calendar/prototypes/wcap/sun-calendar-event-dialog.js&rev=1.27&mark=1632-1633#1625

I think this should be changed together with Bug 360533 to avoid unnecessary changes.

Comment 3

[Simon Paquet [:sipaq]]

I'll try to fix this.

Comment 5

[Simon Paquet [:sipaq]]

Attachment: Patch v1

This patch fixes the issue in this bug as well as bug 360533 (see bug 360533 comment 2)

Comment 6

[Vlado Valastiak [:wladow]]

Well, I think this is not good idea to change values of entities without changing their names. Localizers won't see any changes in tinderbox.

Comment 7

[Simon Paquet [:sipaq]]

Attachment: Patch v2

Same as v1, but with renamed entities as suggested by Vlado

Comment 8

[Stefan Sitter [:ssitter]]

Comment on attachment 278103 [details] [diff] [review]
Patch v2

This patch misses the corresponding changes in the .xul file.

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 278103 [details] [diff] [review]
Patch v2

Please put the localization strings in locales/en-US/chrome/prototypes/sun-calendar-event-dialog.*  for now, since this belongs to the prototype dialog.

Also, locale strings should be camelCase, i.e make the first letter lowercase.

r+ with that fixed. Stefan, which part of the xul file needs to be changed?

Comment 10

[Stefan Sitter [:ssitter]]

(In reply to comment #9)
> Stefan, which part of the xul file needs to be changed?

The part in sun-calendar-event-dialog.xul that references the no longer existing entities event.menu.options.url.label and event.toolbar.document.label. This parts need to be changed to reference the new entities.

Comment 11

[Simon Paquet [:sipaq]]

I'll fix the open issues on checkin

Comment 12

[Simon Paquet [:sipaq]]

Patch v2 checked in on HEAD and MOZILLA_1_8_BRANCH with Philipp's and Stefan's review comments addressed.

Comment 13

[Michael Wolf]

I tested patch v2 and it works. I used lightning.xpi from 2007-8-24 6.56 PTZ, without patch. So I had to work the patch into yet and to change the sun-calendar-event-dialog.xul. But it works, both the dialog (now Add Link instead of Documents) is translated now and the Save dialog as well.

Comment 14

[Stefan Sitter [:ssitter]]

Verified using Mozilla/5.0 (Windows; U; Windows NT 5.0; lt; rv:1.8.1.7pre) Gecko/20070825 Calendar/0.7pre.