393312 - Fork tabbrowser code into Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

If I'm reading Bug 339964 correctly, our tabs code is going to be unhappy with tomorrow's build since we're depending on a bunch of tab code that just got moved to browser. We'll probably have to fork that code in to thunderbird too.

Comment 1

[Scott MacGregor]

Attachment: work in progress

Uggh, a lot of code being forked...

This gets us most of the way there. To do:

1) I don't have access to mac to see how the pinstripe changes are working.
2) There's still some tabbrowser specific code I've added to tabmail.xml which we should be able to remove or do something different with, I just haven't figured out what.

Comment 2

[[e-mail]]

Won't you just get a standard tabstrip instead of a tabbrowser tabstrip?
(OK, so you won't be able to close any tabs with the mouse, but hey...)

Comment 3

[David :Bienvenu]

I tried a tabstrip first - it's a much inferior experience, both in functionality and appearance. But w/o the patch, no, we use some properties that only exist in the tabbrowser class, so tabs don't work at all.

Comment 4

[David :Bienvenu]

module the license stripping issue in the xml file, this patch works for me on the mac.

Comment 5

[Scott MacGregor]

Attachment: updated fix

mail tabs want to start partying on the trunk again....

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 278136 [details] [diff] [review]
updated fix

r=me, I'd rather get back in the game, and then sweat the details in separate bugs where it's clear what we're changing and why, with one nit-exception:

>Index: locales/en-US/chrome/messenger/tabmail.dtd
>===================================================================
>RCS file: locales/en-US/chrome/messenger/tabmail.dtd
>diff -N locales/en-US/chrome/messenger/tabmail.dtd
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ locales/en-US/chrome/messenger/tabmail.dtd	24 Aug 2007 23:18:11 -0000
>@@ -0,0 +1,12 @@
>+<!ENTITY  untitledTab            "(Untitled)">
>+<!ENTITY  newTab.label           "New Tab">
>+<!ENTITY  newTab.accesskey       "N">
>+<!ENTITY  closeTab.label         "Close Tab">
>+<!ENTITY  closeTab.accesskey         "c">
>+<!ENTITY  closeOtherTabs.accesskey  "o">
>+<!ENTITY  closeOtherTabs.label   "Close Other Tabs">
>+<!ENTITY  reloadAllTabs.label    "Reload All Tabs">
>+<!ENTITY  reloadAllTabs.accesskey         "A">
>+<!ENTITY  reloadTab.label        "Reload Tab">
>+<!ENTITY  reloadTab.accesskey         "r">
>+<!ENTITY  listAllTabs.label      "List all tabs">

The "whitespace in the style of a drunk staggering home from a bar" in that file has always gotten on my nerves - please realign it in absolutely any style other than what Fx's copy has.


>+            this.mCloseButtons = pb2.getIntPref("browser.tabs.closeButtons");

We're going to need to decide fairly quickly which of those tab prefs we're going to support, and under what name, before we wind up having to support what's there just because it was there.

Comment 7

[Scott MacGregor]

Fixed, including the drunken spacing. filed bug 393666 for figuring out the tab behavior pref story. Thanks for the review Phil!