Format=flowed class not used for quoting

VERIFIED FIXED in M17

Status

MailNews Core
MIME
P3
normal
VERIFIED FIXED
18 years ago
10 years ago

People

(Reporter: BenB, Assigned: BenB)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: r=rhp, a=waterson, URL)

Attachments

(1 attachment)

(Assignee)

Description

18 years ago
One of the big advantages of format=flowed is, that the client can savely rewrap
quotes, avoiding that other mailers mess them up by rewrapping them badly.*

We are supposed to support flowed, we should insert flowing paragraphs as such
and not fixed lines in the composer while quoting. I.e. use HTML-style quoting
even for nested flowed quotes.

Currently
1. we don't used the flowed class at all for quoting, but the normal plain text
class, which of course results in lots of hard linebreaks.
2. the flowed class doesn't seem to handle the quoting case (where less 
formatting is needed, the sig should be removed etc.).

This bug will be some work, but is important to fix.

Assigning to rhp for now.

*
<quote src="ftp://venera.isi.edu/in-notes/rfc2646.txt">
1.  Abstract

   Interoperability problems have been observed with erroneous labelling
   of paragraph text as Text/Plain, and with various forms of
   "embarrassing line wrap." (See section 3.)

   Attempts to deploy new media types, such as Text/Enriched [RICH] and
   Text/HTML [HTML] have suffered from a lack of backwards compatibility
   and an often hostile user reaction at the receiving end.

[...]

3.2.  Embarrassing Line Wrap

   As Text/Plain messages get quoted in replies or forwarded messages,
   the length of each line gradually increases, resulting in
   "embarrassing line wrap." This results in text which is at best hard
   to read, and often confuses attributions.

      Example:

            >>>>>>This is a comment from the first message to show a
            >quoting example.
            >>>>>This is a comment from the second message to show a
            >quoting example.
            >>>>This is a comment from the third message.
            >>>This is a comment from the fourth message.

   It can be confusing to assign attribution to lines 2 and 4 above.
</quote>

Comment 1

18 years ago
Ben, do you think mimetpfl will be ready to use with your changes in 31906?

Have you identified what need to be done and can summarize it here?
(Assignee)

Comment 2

18 years ago
- It misses some special cases for the quoting case. IIRC, I fixed it in some

cases, but not all. Shouldn't be too hard to fix, but not trivial.

- We really shouldn't send out nbsp just to get fixed lines. We have to use pre

at least in the quoting case (better always IMO). This change is a bit larger; I

did the first small steps with the (by default diabled) flag FLOWED_PRE. It is

solveable, though. E.g.

  - quoting

    - flowed paragraphs*: pre wrap

    - fixed lines: pre wrap

  - viewing wrap=on

    - flowed paragraphs*: pre wrap

    - fixed lines: pre wrap

  - viewing wrap=off

    - flowed paragraphs*: pre wrap

    - fixed lines: pre

  *the whole paragraph is one ling line; the same as the qp text converter does

The proposed tags are open for discussion.



No, I didn't do much for this, because

- the class is very hard for me to read, becausue the writing style is so

different to mine.

- flowed doesn't work on Unix currently (I filed a bug).

Updated

18 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → M19
(Assignee)

Comment 3

18 years ago
Task about &nbsp; (see my last comment) moved to bug 39728.
No longer blocks: 39370
No longer depends on: 39370

Comment 4

18 years ago
Changing qa assign to pmock@netscape.com
QA Contact: lchiang → pmock
(Assignee)

Updated

18 years ago
Depends on: 40862
(Assignee)

Comment 5

18 years ago
2. in the inital description moved to bug 40862. This (39370) bug is now only
about actually using mimetpfl for quoting, if the source is format=flowed.
Shouldn't be hard, but will most likely have to be done by rhp (i.e. not me).
(Assignee)

Updated

18 years ago
Assignee: rhp → mozilla
Status: ASSIGNED → NEW
(Assignee)

Comment 6

18 years ago
This was an easy kill. Took me ~1 min to figure out what's wrong :). Attaching
patch.
(Assignee)

Comment 7

18 years ago
ASSIGNING to me.

rhp or Daniel (whoever wrote the original bits), can you review please?
Status: NEW → ASSIGNED
Whiteboard: Fixed. Waiting for review, approval, checkin.
Target Milestone: M19 → M17
(Assignee)

Comment 8

18 years ago
BTW: This bug propably appeared because of bug 40862.
(Assignee)

Comment 9

18 years ago
Created attachment 10400 [details] [diff] [review]
Fix 1.

Comment 10

18 years ago
Ben, can you make sure that this doesn't break bug 23418 and bug 29267, the 
reasons that exception was done. 
(Assignee)

Comment 11

18 years ago
Daniel, bug 23418 seems to be unrelated. Commented on 29267.

BTW: Found bug 43388 during testing (in case you will run into it while doing so
as well).
(Assignee)

Updated

18 years ago
Keywords: patch
(Assignee)

Updated

18 years ago
Keywords: approval
(Assignee)

Comment 12

18 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
Whiteboard: Fixed. Waiting for review, approval, checkin.
(Assignee)

Updated

18 years ago
Whiteboard: r=rhp, a=waterson

Comment 13

18 years ago
Verified as fixed on win32, linux, and macos using the following builds:
 win32 commercial seamonkey build 2000-102509-mn6 installed on P500 Win98
 linux commercial seamonkey build 2000-102509-mn6 installed on P200 RedHat 6.2
 macos commercial seamonkey build 2000-102508-mn6 installed on G3/400 OS 9.04
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.