40862 - Make flowed class useable for quoting

Status: RESOLVED FIXED

(MailNews Core :: MIME, defect, P3)

Description

[Ben Bucksch (:BenB)]

mime/src/mimetpfl.cpp misses some special cases for the quoting case. Something
like writing prefs into the generated HTML (what we do right now) is bad during
display, but unacceptable if the HTML code is send out as HTML msg.

Check the class if it honors all modes, but at least ...Quoting, ...Bodyquoting
and ...SaveAs(HTML) correctly. Basic work for this has been done with bug 31906.

Comment 1

[Ben Bucksch (:BenB)]

Adding dependencies.

Comment 2

[Ben Bucksch (:BenB)]

M17 for now.

Comment 3

[Ben Bucksch (:BenB)]

Nearly completely fixed with bug 31906. The only remaing issue is doing the
right thing for the signature (see bug 9202).

Comment 4

[Ben Bucksch (:BenB)]

I have this fixed in my tree. Need to do more testing. Writing out patch in case
somebody is interested (Daniel?).

Patch contains fix for bug where quoted empty lines are aten, propably
introduced by the flowed pp (linebreak) bug. I might file a new bug on this.

Daniel, we should file a bug on the nbsp in tag bug as well. (Patch also
included.)

Some source cosmetic.

Comment 5

[Ben Bucksch (:BenB)]

Attachment: Current state of work

Comment 6

[Ben Bucksch (:BenB)]

Filed bugs 43455 and 43453 about the other bugs mentioned, so the world is in
order :).

Comment 7

[Ben Bucksch (:BenB)]

Created new patch. Now excludes fix for bug 43455, but still includes fix for
bug 43453, because it touches the same part as this one.

Daniel, can review the code, please?

Comment 8

[Ben Bucksch (:BenB)]

Attachment: Fix, version 2

Comment 9

[Ben Bucksch (:BenB)]

Daniel did a partial review (thanks!). I'll attach a new patch, incorporating
the changes.

Rich, as Daniel currently can't compile, could you review, please?

Comment 10

[Ben Bucksch (:BenB)]

Attachment: Fix, version 3

Comment 11

[Ben Bucksch (:BenB)]

The "static" in the patch was unnecessary nonsense. Just remove it.

Comment 12

[Ben Bucksch (:BenB)]

Attachment: Fix, version 4

Comment 13

[Ben Bucksch (:BenB)]

Attachment: Fix, version 5

Comment 14

[Ben Bucksch (:BenB)]

The <div>, with bug 39370 now actually sent out, exposes a bug in 4.x'
editor. I removed it in the quoting case (i.e. when a reply is
generated).

Unfortunately, this removes the information about the source format. I
now can't justity anymore to impose a <tt> (which is unnecessary in most
case) on recipients. Removing that as well. See "Embed quotes in <tt> or
not?" on .mailnews for more info.

Comment 15

[Ben Bucksch (:BenB)]

Fix checked in.

Comment 16

[Ben Bucksch (:BenB)]

Forgot the r= and a= in the checkin comment :(.