Make flowed class useable for quoting

RESOLVED FIXED in M17

Status

MailNews Core
MIME
P3
normal
RESOLVED FIXED
18 years ago
10 years ago

People

(Reporter: BenB, Assigned: BenB)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: r=rhp, a=waterson)

Attachments

(5 attachments)

(Assignee)

Description

18 years ago
mime/src/mimetpfl.cpp misses some special cases for the quoting case. Something
like writing prefs into the generated HTML (what we do right now) is bad during
display, but unacceptable if the HTML code is send out as HTML msg.

Check the class if it honors all modes, but at least ...Quoting, ...Bodyquoting
and ...SaveAs(HTML) correctly. Basic work for this has been done with bug 31906.
(Assignee)

Comment 1

18 years ago
Adding dependencies.
Blocks: 39370
Status: NEW → ASSIGNED
Depends on: 39728
(Assignee)

Comment 2

18 years ago
M17 for now.
Target Milestone: --- → M17
(Assignee)

Comment 3

18 years ago
Nearly completely fixed with bug 31906. The only remaing issue is doing the
right thing for the signature (see bug 9202).
Whiteboard: Nearly completely fixed with bug 31906. Remaing is to do the right thing for sig (see bug 9202).
(Assignee)

Comment 4

18 years ago
I have this fixed in my tree. Need to do more testing. Writing out patch in case
somebody is interested (Daniel?).

Patch contains fix for bug where quoted empty lines are aten, propably
introduced by the flowed pp (linebreak) bug. I might file a new bug on this.

Daniel, we should file a bug on the nbsp in tag bug as well. (Patch also
included.)

Some source cosmetic.
Whiteboard: Nearly completely fixed with bug 31906. Remaing is to do the right thing for sig (see bug 9202). → Fixed. Need to test more.
(Assignee)

Comment 5

18 years ago
Created attachment 10435 [details] [diff] [review]
Current state of work
(Assignee)

Comment 6

18 years ago
Filed bugs 43455 and 43453 about the other bugs mentioned, so the world is in
order :).
(Assignee)

Comment 7

18 years ago
Created new patch. Now excludes fix for bug 43455, but still includes fix for
bug 43453, because it touches the same part as this one.

Daniel, can review the code, please?
Whiteboard: Fixed. Need to test more. → Fixed. Waiting for review, approval, checkin.
(Assignee)

Comment 8

18 years ago
Created attachment 10532 [details] [diff] [review]
Fix, version 2
(Assignee)

Comment 9

18 years ago
Daniel did a partial review (thanks!). I'll attach a new patch, incorporating
the changes.

Rich, as Daniel currently can't compile, could you review, please?
Keywords: patch
(Assignee)

Comment 10

18 years ago
Created attachment 10682 [details] [diff] [review]
Fix, version 3
(Assignee)

Comment 11

18 years ago
The "static" in the patch was unnecessary nonsense. Just remove it.
(Assignee)

Comment 12

18 years ago
Created attachment 10876 [details] [diff] [review]
Fix, version 4
(Assignee)

Updated

18 years ago
Whiteboard: Fixed. Waiting for review, approval, checkin. → Fixed. Waiting for approval, checkin.
(Assignee)

Comment 13

18 years ago
Created attachment 10886 [details] [diff] [review]
Fix, version 5
(Assignee)

Comment 14

18 years ago
The <div>, with bug 39370 now actually sent out, exposes a bug in 4.x'
editor. I removed it in the quoting case (i.e. when a reply is
generated).

Unfortunately, this removes the information about the source format. I
now can't justity anymore to impose a <tt> (which is unnecessary in most
case) on recipients. Removing that as well. See "Embed quotes in <tt> or
not?" on .mailnews for more info.
(Assignee)

Updated

18 years ago
Keywords: approval
(Assignee)

Comment 15

18 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
Whiteboard: Fixed. Waiting for approval, checkin.
(Assignee)

Comment 16

18 years ago
Forgot the r= and a= in the checkin comment :(.
Whiteboard: r=rhp, a=waterson
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.