393813 - recently-closed tabs menu disabled, can't reopen tabs

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect, P3)

Description

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007082504 Minefield/3.0a8pre

Tab was closed too soon
Recently Closed gives no joy
Error Console mocks

Error: this._windows[aWindow.__SSi] has no properties
Source File: file:///Applications/Minefield.app/Contents/MacOS/components/nsSessionStore.js
Line: 662

Error: uncaught exception: [Exception... "'[JavaScript Error: "this._windows[aWindow.__SSi] has no properties" {file: "file:///Applications/Minefield.app/Contents/MacOS/components/nsSessionStore.js" line: 662}]' when calling method: [nsISessionStore::getClosedTabCount]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://browser/content/browser.js :: PHM_toggleRecentlyClosedTabs :: line 6487"  data: yes]

(I have the privacy_level thing set to permit SSL pages in session store, but the pages in question weren't SSL, so \/\/.)

Comment 1

[Simon Bünzli]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007082620 Minefield/3.0a8pre

WORKSFORME on a clean profile. So this either is a Mac issue or a profile issue.

Mike: Care to test whether this is also broken in Safe-mode resp. on a new profile? If so, knowing the regression window would surely help.

BTW: The error indicates that for some reason SessionStore wasn't correctly initialized for the whole window which usually happens when there are non-related errors during delayedStartup.

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

I'm pretty sure I've re-opened tabs previously in this Firefox incarnation, so it's not an all-or-nothing thing.  I didn't see any errors on startup, that I recall.

It doesn't happen with a fresh profile.  I don't have any add-ons enabled except DOM Inspector.

The instance is still running, if there's data that someone would like me to collect.

Comment 3

[Simon Bünzli]

How reproducible is the issue?

If you can always reproduce this, it would help to know what causes the issue: most interesting would be to know if the issue can still be reproduced on a clone of the profile with just prefs.js missing (in case you somehow toggled either browser.sessionstore.enabled or a different pref which causes this breakage).

If you can't always reproduce this, you might want to have Dietrich have a look at that profile (IIRC he's mostly on OS X).

(BTW: I suppose that you remember to manually set javascript.options.showInConsole to true again or you won't see any errors.)

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Until we get some solid STR, we can't block on this. Clearing the nomination for now ...

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

I can reproduce this every time. Note that my steps are OS X specific:
1. Start firefox, a new window opens.
   -> Note that Undo Close Tab works in this window.
2. Close the window (not quitting the app).
   -> There are now 0 visible windows.
3. Open a new window via cmd+n or the file menu.
4. Undo Close Tab no longer works in any window.

I also notice that if perform an action, such as an update, then the restored windows after the restart are from the first window that was closed (that is, the one that caused us to go from 1 visible window to 0 visible windows).

Comment 6

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Aw yeah, bkap bustin' out the STR.  Boo-yah!

Comment 7

[Ian Weller]

I have this same problem. When I click on the History menu it takes about half a second more than it should to load, and when it does load the "Recently Closed Tabs" submenu is disabled, and Firebug catches the following error:
  this._windows[aWindow.__SSi] has no properties
  file:///F:/apps/FirefoxPortable/App/firefox/components/nsSessionStore.js
  Line 671

Yes, I'm using FirefoxPortable. And, this bug only appears to happen at my local library, which has god-knows-what software running in the background to keep my session tied to a certain time. It works everywhere else. I'm not sure what's going on, but I hope that this is all the information needed.

Comment 8

[Ian Weller]

I just relaunched Firefox (not in safe mode, regularly) and it works now. It's a really awkward bug. :/

User agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.7) Gecko/20070914 Firefox/2.0.0.7

Comment 9

[Daniel Brooks [:db48x]]

I can reproduce on linux, simply by opening a second window. I get a different error though:

Error: [Exception... "'Component is not available' when calling method: [nsIHandlerService::getTypeFromExtension]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "<unknown>"  data: no]

(twice)

Comment 10

[Daniel Brooks [:db48x]]

Oh, my apologies for the spam. I didn't wait long enough for a page to load in the tab in the second window before closing it, so it didn't get added to the menu.

Comment 11

[Elmar Ludwig]

(In reply to comment #9)
> I can reproduce on linux, simply by opening a second window. I get a different
> error though:

This seems to be a different problem, though the effect is similar. I filed bug 400738 on this issue (and CC'ed you in case you are interested). I also see the error you mention, but that happens on startup for me and seems to be unrelated.

Comment 12

[Ian Weller]

I think I may have solved this bug.

I have found that this occurs on OS X and Windows. Hmm. "Might be due to an extension," I say to myself, since it is cross-platform. It also occurs cross-version -- I have 2.0.0.0 on OS X, 2.0.0.8 on Windows, and Mike Shaver has this bug in 3.0a8.

I also just found out that Mike Shaver and I are having *basically* the same exact problem, within the same exact file, while nobody else is piping up and saying "yeah this is happening." So it probably is due to an extension.

And, I booted Firefox in safe mode, and -- you guessed it -- it worked. So it is an extension.

Since this hasn't been happening until recently, I started with the most recently added one, "Facebook Toolbar." This is the toolbar that Facebook mashed together and put in their own applications directory. Upon disabling it, and doing a bunch of random tab opening and closing, the problem appears to be fixed.

The only other extensions I have in both copies of my browsers are Adblock Plus, Filterset.G for Adblock, Firebug, and Stylish. I know Firebug isn't doing it, because it's not causing any problems on my Linux box (Firefox version 2.0.0.1, Fedora Core 6, using rpm with an i386 build). I don't have any themes installed.

Mike: If you have Facebook Toolbar, and disabling it causes the bug to be fixed, I say we mark this puppy as INVALID. If not, we got something else crazy on our hands.

logic ftw \o/

Comment 13

[Dave Townsend [:mossop]]

Ian, just because noone else has chimed in to say they are having the problem doesn't mean there aren't those of us out there, we just avoid the pointless "me too" comments.

I have none of the extensions you have and see this frequently.

Comment 14

[Blake Kaplan (:mrbkap) (inactive)]

(In reply to comment #12)
> I also just found out that Mike Shaver and I are having *basically* the same
> exact problem, within the same exact file, while nobody else is piping up and
> saying "yeah this is happening." So it probably is due to an extension.

Did you read comment 5?

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

Testing on 3.0b1 today and the menu is disabled no matter what I try.

Comment 16

[Dave Townsend [:mossop]]

Attachment: patch rev 1

The problem here is that under certain conditions (like closing the last visible window on OSX) we consider quitting the app. The quit gets cancelled but before then we dispatch a quit-application-granted notification which sessionstore uses to decide to stop doing anything believing that the app is quitting.

This patch moves the notification to later in the process to a point when we have decided to definitely try quitting.

Comment 17

[Dave Townsend [:mossop]]

Technically a regression from bug 372453 for the STR in comment 5

Comment 18

[Dave Townsend [:mossop]]

Checking in toolkit/components/startup/src/nsAppStartup.cpp;
/cvsroot/mozilla/toolkit/components/startup/src/nsAppStartup.cpp,v  <--  nsAppStartup.cpp
new revision: 1.21; previous revision: 1.20
done

Comment 19

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9b2pre) Gecko/2007120504 Minefield/3.0b2pre. I verified using steps in Comment 5.