393944 - Selecting Gold Star adds site to Bookmarks when searched but bookmark does not show up in any view

Status: VERIFIED DUPLICATE of bug 393547

(Firefox :: Bookmarks & History, defect)

Description

[Al Billings [:abillings - ex-MoCo]]

If a user goes to a site that isn't currently bookmarked and selects the Gold Star, the site is bookmarked (I assume in the "All Bookmarks" mystery folder that shows up in the dialog if you click on the Gold Star again).

If the user then goes to the Bookmarks Manager or the Bookmarks Sidebar and searches for this site, it can be found like any other bookmark in the search. Other than this, the bookmarks does not show up in any views in either the sidebar, the manager, or the bookmarks menu.

Looks in places.sqlite, I see that the item is in the moz_bookmarks table with its parent set to "1" in it. The bookmarks folder and other items that I have tagged with the Gold Star are the only other items with their parent set to "1" in the file.

I would expect that if the Gold Star adds the url being displayed to all bookmarks, that it would show up in the menu, manager, or sidebar. Otherwise, it is completely inaccessible to the user unless they select another folder.

Comment 1

[Al Billings [:abillings - ex-MoCo]]

Found in Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007082704 Minefield/3.0a8pre.

Comment 2

[(not reading, please use [e-mail] instead)]

I think they are being added to the "All bookmarks" view, but we're not showing that in the organizer yet.

this might be a dup.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

these bookmarks will be displayed by going to the bookmarks menu and selecting "all bookmarks" which will load the organizer.  We are not placing bookmarks created with the star in the bookmarks menu itself because the user may star thousands of pages.

Comment 4

[Al Billings [:abillings - ex-MoCo]]

All right. Is this plan documented somewhere. Since I'm one of the two QA working on this area, it would be good if I could find out these things before logging the bugs. That would save us all time and energy.

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

>All right. Is this plan documented somewhere.

Sorry we didn't send the mockups to the QA team earlier.  You can view all the UI design work for Places in this dependancy tree: https://bugzilla.mozilla.org/showdependencytree.cgi?id=393529&maxdepth=1&hide_resolved=0

There are some interactions between the mockups (like the star in the location bar and the "all bookmarks" section of the organizer), so you will probably need to review all of them to get the full picture.

A discussion of the most recent set of mockups is going on in this thread on dev.apps.firefox: http://groups.google.com/group/mozilla.dev.apps.firefox/browse_thread/thread/3b97116909cebef0/7a4917955e295604#7a4917955e295604

Comment 6

[(not reading, please use [e-mail] instead)]

this was addressed by mano's landing of bug #387746, as now you can find the "Unfiled Bookmarks" folder in the places organizer.

Comment 7

[(not reading, please use [e-mail] instead)]

fixed by mano's fix for bug #387746

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv