Closed Bug 393998 Opened 17 years ago Closed 16 years ago

Next button in new calendar dialog is disabled when changes are cancelled

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: omar.bajraszewski, Assigned: ingomu)

References

Details

Attachments

(2 files)

STEPS TO REPRODUCE:
===================

-Select new calendar
-Select "On the network"
-Select Next and type something in location
-Select Back

RESULT:
=======

-Next button is inactive

EXPECTED RESULT:
================

-The next button should be active

REPRODUCIBLE:
=============

- always


I reproduced it with Sunbird 0.5 and lightning 2007082803 and Mozilla/5.0 (Windows; U; Windows NT 5.1;
en-US; rv:1.8.1.7pre) Gecko/20070827 Calendar/0.7pre
Summary: Next button in new calendar dialog are disabled when changes are cancelled → Next button in new calendar dialog is disabled when changes are cancelled
OS: Windows XP → All
Hardware: PC → All
WFM in the latest 0.8pre nightlies.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WORKSFORME
WFM
Issue from Comment #0 can still be reproduced using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12pre) Gecko/2008020404 Calendar/0.8pre.

The Next button will only be enabled if you enter some useful URL (e.g. "http:"). If you don't do this the Next button stays disabled even if you go back to the previous wizard page.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Doesn't work for me... See patch in Bug 427131
Assignee: nobody → ingomu
Status: REOPENED → NEW
Comment on attachment 313960 [details] [diff] [review]
Patch carried over from bug 427131

>-        if (canAdvance && document.getElementById("calendar-uri").value)
>+        if (canAdvance && document.getElementById("calendar-uri").value
>+                       && curPage.getAttribute("pageid") == "locationPage")
>             canAdvance = checkURL();
While you are at it, please add brackets to the if-block. Also, put the && at the end of the previous line and align the curPage... with canAdance. Please use the curPage.pageid shortcut instead of getAttribute.

This might not be the ideal way to go, since checkRequired() is quite general and special casing inside it might not be the best way, but this code needs to be overhauled anyway to allow for custom new calendar wizards.

r=philipp with style fixed.
Attachment #313960 - Flags: review+
Attachment #313964 - Flags: review?
Comment on attachment 313964 [details] [diff] [review]
Same patch as above but with style fixed

r=philipp
Attachment #313964 - Flags: review? → review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [checkin-needed after 0.8]
Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [checkin-needed after 0.8]
Target Milestone: --- → 0.9
Yohooo, I was helpfull! ;-)
Checked in nightly build (Lightning 2008041318/Sunbird 20080413) -> task is verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: