394011 - Legend for printing multiple calendars in weekly or monthly grid view

Status: NEW

(Calendar :: Printing, enhancement)

Description

[Marco van Beek]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.6) Gecko/20070725 Firefox/2.0.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/20070614 Sunbird/0.5

When printing (and previewing) multiple calendars in either weekly or monthly view, the different calendars are displayed in different colours. However, there is no legend on the printout that tells you which diary it is, so once it is printed out and given to someone, it becomes impossible to distinguish which colour relates to which calendar.

Reproducible: Always

Steps to Reproduce:
1. Set up multiple calendars.
2. File > Print > weekly (or monthly) grid.
3. The printout does not display any information regarding which colour is which.


Expected Results:  
Legend with calendar name should be included on printout

There is a similar issue with list view, which is monochrome, and therefore even worse. However, the list view has the space to include the persons name in each event.

Comment 2

[PM]

Attachment: Patch for printing the names and colors of calendars and categories

This patch prints the names and colors of calendars and categories for weekly and monthly models.
Names and colors are printed on the first page only.
The values are obtained from the elements to be printed.
The preview1.png image gives an overview.

For weekly model, i did also removed the height attribute  in mainWeek table, to avoid printing the first week on two pages.

Comment 3

[PM]

Attachment: preview1.png

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 589841 [details] [diff] [review]
Patch for printing the names and colors of calendars and categories

Philippe, could you possibly make the legend a bit less dominant? I could imagine something like this:


 Calendars                              Categories

▅▅ Agenda principal                   ▭ Appels
▦▦ Agenda de test                     ▭ Tests


where ▅▅,▦▦ is a small full solid color box and  ▭ is a box with transparent fill and a category-colored border.

I'll ask andreasn for feedback on the legend though, as he will be doing the ui-review.


Aside from that the following review comments, some improvements could be made:

>+    getStringForCalendars: function getStringForCalendars(aItems) {
...
>+          let color=pb2.getCharPref("calendar.registry."+item.calendar.id+".color");
>+          calendars[name]=color; 
I believe you can just do item.calendar.getProperty("color"); 

>+      
>+      cal.loadScripts(["calUtils.js"], this.__parent__);

Instead of loading calUtils into the parent scope (I think __parent__ is deprecated on trunk, too), you should be able to load calUtils.jsm using Components.utils.import() and then just prefix all functions from calUtils.js with "cal.".

Setting r- for now, I'd suggest you wait for feedback from andreasn, fix the patch and then ask for review again.

Comment 5

[Stefan Sitter [:ssitter]]

IMHO there should be at least a hidden preference to turn off adding calendar list / categories list. In a follow-up bug this preference could be exposed in the print dialog too.

Comment 6

[Andreas Nilsson (:andreasn)]

Comment on attachment 589841 [details] [diff] [review]
Patch for printing the names and colors of calendars and categories

Turning feedback request flag off.
I keep getting reminders about this, but it's been quite a while I looked at anything calendar related, that's it's probably better for someone else to do it.