Closed Bug 394049 Opened 17 years ago Closed 17 years ago

Fix CrashReporter strings for XULRunner apps with no 'vendor'

Categories

(Toolkit :: Crash Reporting, defect)

Product:
Toolkit
Component:
Crash Reporting
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: bent.mozilla, Unassigned)

References

Details

Right now the strings default to "Send crash report to Mozilla" if you don't have a vendor string. We've hacked this to say "Songbird" because that's what our product people wanted... but I guess that won't work for every app. Thoughts?
I think we either need to come up with a generic string that works there (since using "Thunderbird" looks silly, for example), or just chop that string to say "Send crash report".

Why does the crash reporter use the Vendor from the application.ini [app] section belonging to the application instead of a separate value in the [Crash Reporter] section belonging to the crash reporter or better asking the server receiving the crash report for the vendor information to display. A request might be specified to ask the crash report server for the company name of the company receiving the crash report in case of the user confirms sending the report to there.

If ToolKit crashes, the crash report may be helpful for the ToolKit developers not for the developers of the application invoking the crash.

So if sending a crash report to ServerURL=https://crash-reports.mozilla.com/submit it is wrong, when the crash reporter says the crash report to be send to vendor "Banana Joe" or what ever the vendor of the crash invoking application is, but it should say "the report will be sent to Mozilla.com" or what ever the official Name of the owner of crash-reports.mozilla.com is.



Because the application.ini specifies the application?  The crashreporter.ini is purely for localization.  While you're correct that other XULRunner-based apps might hit crashes in toolkit code, it's not feasible to determine that and submit reports elsewhere, especially since analyzing the crash report requires the debug symbols from that particular build.

This bug doesn't need a complicated solution.

Just similar.  The other one is about the fact that we say "restore your tabs and windows" and whatnot.  This one is just about the phrasing "Send crash report to Mozilla" if no vendor is specified.

I think this bug might be irrelevant once I fix bug 412989, since you'll be able to override any strings you want.

Well, what happens if someone wants to substitute a different value into a string? Songbird, for instance, wanted the text to say "submit report to NAME" instead of "submit report to VENDOR"...
You can just replace the whole string.  I guess that sucks if you want localized versions, though.

Gonna call this WFM for now.  In an ideal world, you'd be able to have arbitrary substitutions in the strings.  Maybe if we roll with bug 409981 at some point in the future, and get l20n in on that.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.