Closed Bug 394085 Opened 16 years ago Closed 15 years ago

The star button is touching the right border of the location bar drop down button

Categories

(Firefox :: Address Bar, defect)

x86
Windows XP
defect
Not set
trivial

Tracking

()

VERIFIED FIXED
Firefox 3 beta1

People

(Reporter: u88484, Assigned: dao)

References

Details

(Keywords: polish)

Attachments

(2 files, 1 obsolete file)

Attached image screenshot
The star button is touching the right border of the location bar drop down button
Workaround to put in userChrome.css

toolbar:not([mode="text"]) #star-button,
#palette-box #star-button {
margin-left: 3px !important;
}
Blocks: 385266
Should we closed this since the button has been moved now? I have been leaving it open since there was talk about moving it back but I'm sure if it was moved back, it would then have the correct margin?
Fixed by bug 387646
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Kurt, I can still see this on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007091504 Minefield/3.0a8pre ID:2007091504
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Attached patch Patch (obsolete) — Splinter Review
Sorry for verifying this fixed, forgot that I had a userChrome.css hack to fix it so that is what this patch is.
Assignee: nobody → supernova_00
Status: REOPENED → ASSIGNED
Attachment #281008 - Flags: review?
Attachment #281008 - Flags: review? → review?(mano)
Comment on attachment 281008 [details] [diff] [review]
Patch

s/margin-left/-moz-margin-start/ These are all very temporary style rules though.

r=mano.
Attachment #281008 - Flags: review?(mano) → review+
Attachment #281008 - Flags: approval1.9?
margin for #star-button means that that area won't be clickable. This would be a better fix:

toolbar:not([mode="text"]) #star-button > .toolbarbutton-icon ,
#palette-box #star-button > .toolbarbutton-icon {
  margin-left: 3px;
  margin-right: 3px;
}

Alternatively you could apply padding to #star-button. But note that the icon has |-moz-margin-end: 5px| by default.
Comment on attachment 281008 [details] [diff] [review]
Patch

hrm, right, thanks.
Attachment #281008 - Flags: review+ → review-
Attachment #281008 - Flags: approval1.9?
Attached patch patchSplinter Review
Assignee: supernova_00 → dao
Attachment #281008 - Attachment is obsolete: true
Attachment #282249 - Flags: review?(mano)
Comment on attachment 282249 [details] [diff] [review]
patch

r=mano
Attachment #282249 - Flags: review?(mano) → review+
Attachment #282249 - Flags: approval1.9?
Attachment #282249 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.css
new revision: 1.102; previous revision: 1.101
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M9
Verified FIXED using:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008011504 Minefield/3.0b3pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.