Status

()

Firefox
General
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: rflint, Assigned: rflint)

Tracking

({perf})

Trunk
Firefox 3 beta1
x86
All
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox3 -
wanted-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

 
Created attachment 271798 [details] [diff] [review]
WIP

The goal of this is to create a single endcap style, reduce the number of images and pare down on the amount of styling and structural elements needed.

Updated

11 years ago
Blocks: 378983
Target Milestone: Firefox 3 M7 → Firefox 3 M8
No longer blocks: 378983
Target Milestone: Firefox 3 M8 → Firefox 3 M9
Created attachment 280018 [details] [diff] [review]
Patch
Attachment #271798 - Attachment is obsolete: true
Attachment #280018 - Flags: review?(mconnor)
Created attachment 280019 [details]
Screenshot

Shown with the patch from bug 24998 applied.
Created attachment 280030 [details] [diff] [review]
Patch v1.1

Bah, forgot to remove the old images from jar.mn.
Attachment #280018 - Attachment is obsolete: true
Attachment #280030 - Flags: review?(mconnor)
Attachment #280018 - Flags: review?(mconnor)
Flags: blocking-firefox3?
OS: Windows XP → All

Updated

10 years ago
Flags: blocking-firefox3? → blocking-firefox3-
Whiteboard: [wanted-firefox3]
Comment on attachment 280030 [details] [diff] [review]
Patch v1.1

r=me, but we should figure out how to kill the stack entirely as a next step
Attachment #280030 - Flags: review?(mconnor) → review+
Attachment #280030 - Flags: approval1.9?

Updated

10 years ago
Attachment #280030 - Flags: approval1.9? → approval1.9+
Checked in with temporary background images. Note that this will make the bottom corner of the button slightly fuzzy until bug 24998 lands.

mozilla/browser/components/search/content/search.xml  1.99
mozilla/browser/base/content/browser.xul  1.372
mozilla/browser/themes/winstripe/browser/browser.css  1.94
mozilla/browser/themes/winstripe/browser/endcap-bkgnd-hover.png  1.3
mozilla/browser/themes/winstripe/browser/endcap-bkgnd.png  1.3
mozilla/browser/themes/winstripe/browser/jar.mn  1.52
mozilla/browser/themes/winstripe/browser/searchbar.css  1.18
mozilla/browser/themes/winstripe/browser/Go-bkgnd-rtl.png delete
mozilla/browser/themes/winstripe/browser/Go-bkgnd.png delete
mozilla/browser/themes/winstripe/browser/Go-mid-bottom-rtl.png delete
mozilla/browser/themes/winstripe/browser/Go-mid-bottom.png delete
mozilla/browser/themes/winstripe/browser/Go-mid-top-rtl.png delete
mozilla/browser/themes/winstripe/browser/Go-mid-top.png delete
mozilla/browser/themes/winstripe/browser/Search-bkgnd-rtl.png delete
mozilla/browser/themes/winstripe/browser/Search-bkgnd.png delete
mozilla/browser/themes/winstripe/browser/Search-mid-bottom-rtl.png delete
mozilla/browser/themes/winstripe/browser/Search-mid-bottom.png delete
mozilla/browser/themes/winstripe/browser/Search-mid-top-rtl.png delete
mozilla/browser/themes/winstripe/browser/Search-mid-top.png delete
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: perf
Resolution: --- → FIXED

Updated

10 years ago
Blocks: 352678

Comment 7

10 years ago
How come the mid-bottom and mid-top images were removed?  Weren't they supposed to create a separator between the star and go button? (Not that it worked before this checkin anyways)
Depends on: 396274
(In reply to comment #7)
> Weren't they supposed to create a separator between the star and go button? (Not > that it worked before this checkin anyways)
> 
No, they were horizontal elements that were repeated to allow the button to scale vertically while keeping the background intact.

Updated

10 years ago
Depends on: 398020
Flags: wanted-firefox3+
Whiteboard: [wanted-firefox3]
You need to log in before you can comment on or make changes to this bug.