387646 - Endcap cleanup

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment 1

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: WIP

The goal of this is to create a single endcap style, reduce the number of images and pare down on the amount of styling and structural elements needed.

Comment 2

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Patch

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Screenshot

Shown with the patch from bug 24998 applied.

Comment 4

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Patch v1.1

Bah, forgot to remove the old images from jar.mn.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 280030 [details] [diff] [review]
Patch v1.1

r=me, but we should figure out how to kill the stack entirely as a next step

Comment 6

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Checked in with temporary background images. Note that this will make the bottom corner of the button slightly fuzzy until bug 24998 lands.

mozilla/browser/components/search/content/search.xml  1.99
mozilla/browser/base/content/browser.xul  1.372
mozilla/browser/themes/winstripe/browser/browser.css  1.94
mozilla/browser/themes/winstripe/browser/endcap-bkgnd-hover.png  1.3
mozilla/browser/themes/winstripe/browser/endcap-bkgnd.png  1.3
mozilla/browser/themes/winstripe/browser/jar.mn  1.52
mozilla/browser/themes/winstripe/browser/searchbar.css  1.18
mozilla/browser/themes/winstripe/browser/Go-bkgnd-rtl.png delete
mozilla/browser/themes/winstripe/browser/Go-bkgnd.png delete
mozilla/browser/themes/winstripe/browser/Go-mid-bottom-rtl.png delete
mozilla/browser/themes/winstripe/browser/Go-mid-bottom.png delete
mozilla/browser/themes/winstripe/browser/Go-mid-top-rtl.png delete
mozilla/browser/themes/winstripe/browser/Go-mid-top.png delete
mozilla/browser/themes/winstripe/browser/Search-bkgnd-rtl.png delete
mozilla/browser/themes/winstripe/browser/Search-bkgnd.png delete
mozilla/browser/themes/winstripe/browser/Search-mid-bottom-rtl.png delete
mozilla/browser/themes/winstripe/browser/Search-mid-bottom.png delete
mozilla/browser/themes/winstripe/browser/Search-mid-top-rtl.png delete
mozilla/browser/themes/winstripe/browser/Search-mid-top.png delete

Comment 7

[u88484]

How come the mid-bottom and mid-top images were removed?  Weren't they supposed to create a separator between the star and go button? (Not that it worked before this checkin anyways)

Comment 8

[Ryan Flint [:rflint] (ping via IRC for reviews)]

(In reply to comment #7)
> Weren't they supposed to create a separator between the star and go button? (Not > that it worked before this checkin anyways)
> 
No, they were horizontal elements that were repeated to allow the button to scale vertically while keeping the background intact.