394183 - Task creation via double click in Task List is broken

Status: VERIFIED FIXED

(Calendar :: Tasks, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.7pre) Gecko/20070829 Calendar/0.7pre

Task creation via double click in Task List is broken

Steps to Reproduce:
1. Start Sunbird with fresh profile
2. Double click in the empty area of the Task List

Actual Results:
New Task dialog is not shown. Error in Console:

  Error: calendar has no properties
  Source File: chrome://calendar/content/calendar-item-editing.js
  Line: 211

Expected Results:
New Task dialog is shown.

Comment 1

[Stefan Sitter [:ssitter]]

Confirmed as regression:

Works in Sunbird 0.7pre (2007082801)
Fails in Sunbird 0.7pre (2007082804)

Checkins during regression range: Bug 393844, Bug 387232 and Bug 361977.

Bug 361977 is most likely the causer, adding dependency.

Comment 2

[Daniel Boelzle [:dbo]]

Hopefully to be fixed with bug 372830.

Comment 3

[Martin Schröder [:mschroeder]]

Daniel, this is definitely a blocker (decision on the QA chat), also if bug 372830 may fix it. Philipp volunteered to have a look at it.

@Christian: Should double clicking at empty space in the task list open the new task dialog?

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix task creation

This does it. The openEventDialog function doesn't set any defaults if you call it without arguments, even though there is a comment somewhere saying thats possible.

Comment 5

[Christian Jansen]

(In reply to comment #3)
> Daniel, this is definitely a blocker (decision on the QA chat), also if bug
> 372830 may fix it. Philipp volunteered to have a look at it.
> 
> @Christian: Should double clicking at empty space in the task list open the new
> task dialog?
> 

It should be possible, but wouldn't we get this automatically with Bug 388418?

Comment 6

[Simon Paquet [:sipaq]]

(In reply to comment #3)
> Daniel, this is definitely a blocker (decision on the QA chat), also if bug
> 372830 may fix it. Philipp volunteered to have a look at it.

<rant>
Can we please try focus more on bringing the list of blocker bugs down instead of putting more and more bugs on it, especially with such a non-obvious power-user feature like this one?

In addition I would really like to have a justification here in the bug on why (minor) bugs like this one should be considered as a blocker.
</rant>

Comment 7

[Martin Schröder [:mschroeder]]

(In reply to comment #6)
> <rant>
> Can we please try focus more on bringing the list of blocker bugs down instead
> of putting more and more bugs on it, especially with such a non-obvious
> power-user feature like this one?
> 
> In addition I would really like to have a justification here in the bug on why
> (minor) bugs like this one should be considered as a blocker.
> </rant>

I will no longer discuss about, triage or look for possible blocker bugs. Maybe someone else feels like doing something nobody wants (but that is needed in my opinion). I don't have time to waste.

Comment 8

[Simon Paquet [:sipaq]]

Moving back to blocker status. My post was not intended to question the blocker status (else I would have already reverted it myself) but to get more information 
on why this bug was moved to blocker status. Unfortunately I can't make it to the 
QA chats most of the time and with the RC1 date coming ever closer, I think a short justification on the why is helpful for everyone in the current distributed release driving process.

Comment 9

[Omar Bajraszewski]

I've applied the patch to see how it works and I haven't noticed any new regressions nor new errors :-)

Comment 10

[Omar Bajraszewski]

When a task is selected task creation via double click in task List in lightning is broken even with the patch. It causes to open an edit task dialog. Deleting the selected task doesn't help.

Patch works good for sunbird but it doesn't resolve the problem for lightning

Comment 11

[Martin Schröder [:mschroeder]]

(In reply to comment #10)
> When a task is selected task creation via double click in task List in
> lightning is broken even with the patch. It causes to open an edit task dialog.
> Deleting the selected task doesn't help.

Omar, this is a known issue (bug 353791). It will be obsolete when patch from bug 372830 has landed

Comment 12

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Guys, please cool down a bit. I understand that we shouldn't consider bugs to be blocker bugs if they are minor, but if you look at the time between the blocker proposal and my patch, you should see that I created it before the QA meeting was even over!

If you are pedantic, you could say that its not a blocker but still goes for 0.7, but since there is a patch that fixes it for the unifinerToDo and lightning is getting the unifinderToDo too, who really gives!?

We can spend all day ranting about what bugzilla field should be set, and fight a war over setting and unsetting it, or we can waste our energy arguing if bugs should block or not, but what we also can do is take that time and just sit down and fix the bugs. Of course that should happen in an order of priority, but after considering the roadmap, thats up to each developer to decide for himself.

I came across this bug more than once and was annoyed that double-clicking wouldn't open the task dialog, so I wanted to have this fixed, and here we are, wasting time discussing if its a blocker or not.

Comment 13

[Daniel Boelzle [:dbo]]

+1

Comment 14

[cmtalbert]

Comment on attachment 279936 [details] [diff] [review]
Fix task creation

(In reply to comment #12)
Amen Philipp!
r=ctalbert

Comment 15

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 16

[Omar Bajraszewski]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.7pre) Gecko/20070908 Calendar/0.7pre