Closed
Bug 372830
Opened 17 years ago
Closed 17 years ago
Integrate UnifinderToDo into Lightning as it is in Sunbird
Categories
(Calendar :: Lightning Only, enhancement)
Calendar
Lightning Only
Tracking
(Not tracked)
VERIFIED
FIXED
0.7
People
(Reporter: giermann, Assigned: michael.buettner)
References
Details
Attachments
(2 files, 6 obsolete files)
13.01 KB,
image/png
|
chris.j.bugzilla
:
ui-review+
|
Details |
136.55 KB,
patch
|
dbo
:
review+
michael.buettner
:
ui-review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2 Build Identifier: Lightning 0.3.1 (build 2007021403) There is no way to display details of a task in task-view of Lightning, nor is there a chance to hide completed task in the release version (although there is another solution in the nightlies). It would be quite easy to integrate the Sunbird UnifinderToDo into Lightning with all the functionality! Reproducible: Always I created a DIFF file on the release-source to do the integration. Unfortunately I could not test the build, but I integrated it into the JARs manually, which worked fine. There should also be a generic discussion, whether the Unifinder function "Hide completed tasks" or the Lightning-nightly function "Show completed tasks" should be used. But I think it is stronlgy recommended to be the same in Sunbird and Lightning. You should note, that no modification to the Unifinder script itself was made!
Reporter | ||
Comment 1•17 years ago
|
||
Attachment #257517 -
Flags: ui-review?(mvl)
Attachment #257517 -
Flags: second-review?(jminta)
Attachment #257517 -
Flags: first-review?(shaver)
Reporter | ||
Comment 2•17 years ago
|
||
Please note, that I created this enhancement together with the integration of Unifinder event-list, as described in bug 372829. Maybe some modifications are needed to integrate both, as I manually separated them to submit this bug.
Version: unspecified → Lightning 0.3.1
Updated•17 years ago
|
Attachment #257517 -
Flags: first-review?(shaver) → first-review?(lilmatt)
Reporter | ||
Comment 3•17 years ago
|
||
Reporter | ||
Updated•17 years ago
|
Attachment #257517 -
Flags: second-review?(jminta) → second-review?(dmose)
Comment 4•17 years ago
|
||
Comment on attachment 257517 [details] [diff] [review] Enhancements to include Unifinder to Lightning dmose, is no longer actively working on Calendar code. Moving review to mvl.
Attachment #257517 -
Flags: second-review?(dmose) → second-review?(mvl)
Comment 5•17 years ago
|
||
Comment on attachment 257517 [details] [diff] [review] Enhancements to include Unifinder to Lightning This does not need a 2nd review anymore, since lilmatt is a module peer.
Attachment #257517 -
Flags: second-review?(mvl)
Updated•17 years ago
|
Whiteboard: [cal-ui-review needed]
Updated•17 years ago
|
Summary: Please integrate UnifinderToDo into Lightning as it is in Sunbird → Integrate UnifinderToDo into Lightning as it is in Sunbird
Comment 6•17 years ago
|
||
will this be added to lightning, possibly as an option?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [cal-ui-review needed] → [cal-ui-review needed] [qa discussion needed]
Attachment #257517 -
Flags: first-review?(lilmatt) → review?(lilmatt)
Whiteboard: [cal-ui-review needed] [qa discussion needed] → [cal-ui-review needed]
Comment 7•17 years ago
|
||
Comment on attachment 257517 [details] [diff] [review] Enhancements to include Unifinder to Lightning removing code review request until we get this through ui-review
Attachment #257517 -
Flags: review?(lilmatt)
Reporter | ||
Comment 8•17 years ago
|
||
For anyone who is still interested in this function, have a look to my extension 'ltnPlus': https://addons.mozilla.org/thunderbird/addon/5285 So it is not nessecary to get the ui-review, but it demonstrates that this is possible by a simple overlay.
Updated•17 years ago
|
OS: Windows XP → All
Hardware: PC → All
Whiteboard: [cal-ui-review needed]
Updated•17 years ago
|
Assignee: nobody → giermann
Updated•17 years ago
|
Status: NEW → ASSIGNED
Comment 9•17 years ago
|
||
Comment on attachment 257517 [details] [diff] [review] Enhancements to include Unifinder to Lightning updating to reality: I won't be able to review this any time soon
Attachment #257517 -
Flags: ui-review?(mvl)
Comment 10•17 years ago
|
||
Some premilimary comments: First, you should update you screenshots to the current layout of Lightning. That will make the UI-review much easier. Please request UI-review from Christian (christian.jansen@sun.com), our only ui-reviewer at the moment. >diff -prU 8 mozilla/calendar/lightning/content/calendar-todo-list.css Why are you changing the license header completely? Most of the changes you make, look like it would be much easier, if you just import the relevant parts from the file, that you copy&pasting this. >diff -prU 8 mozilla/calendar/lightning/content/todo-list-overlay.xul > >+ <!-- SG, 20.02.2007 - added from Sunbird (/content/calendar/calendar.xul) Please remove these comments. With all the copy&paste work you're doing, it would make much more sense, to consolidate the relevant code parts into one file and use that. All this copy&paste work all over the tree, will make code maintenance much harder in the long run. >diff -prU 8 mozilla/calendar/lightning/content/todo-list.js Same as above. >diff -prU 8 mozilla/calendar/lightning/jar.mn You should not make these changes to calendar/lightning/jar.mn, but to calendar/base/jar.mn. That would also allow you to remove the relevant entries from calendar/resources/jar.mn
Reporter | ||
Comment 11•17 years ago
|
||
I wait to get this through UI-review until I spend more time on this. If this is the desired way to go, it would save the separate development of the Lightning todo-list, but would need to check for every reference to the 'Show completed tasks' checkbox.
Attachment #257652 -
Attachment is obsolete: true
Attachment #274747 -
Flags: ui-review?(christian.jansen)
Comment 13•17 years ago
|
||
(In reply to comment #11) > Created an attachment (id=274747) [details] > Screenshot of Unifinder ToDo list in Lightning 0.7pre (20070731) > [...] This looks really great and behaves much better than the to do list we have today. Would it be possible to extend the UnifinderToDo list by features described in [1]? This would aling better to the "long term (1.0)" UI goal [2] of the Today Pane. [1] http://wiki.mozilla.org/Calendar:Mail_View_Integration#Task_Tree [2] http://wiki.mozilla.org/Image:Today-pane1.png
Comment 14•17 years ago
|
||
(In reply to comment #11) > Created an attachment (id=274747) [details] > Screenshot of Unifinder ToDo list in Lightning 0.7pre (20070731) > [...] This looks really great and behaves much better than the to do list we have today. Would it be possible to extend the UnifinderToDo list by features described in [1]? This would align much better with the "long term (1.0)" UI goal [2] of the Today Pane. [1] http://wiki.mozilla.org/Calendar:Mail_View_Integration#Task_Tree [2] http://wiki.mozilla.org/Image:Today-pane1.png
Comment 15•17 years ago
|
||
I like the idea of having the unifinder in Lightning, but 1) I hope that the unifinder will be optional in month view (at least). One of my favorite things about Lightning is its clean simple month view, it's like a real wall calendar, and I think that the unifinder would (a) make it look ugly, (b) be too technical for some Lightning users, and (c) use precious screen space even if some people never use it. 2) However, for people who would hide the unifinder in month view, it would be great if we could look at it in a dedicated view like the others: Day/Week/Multiweek/Month/Unifinder. Maybe instead of "Unifinder View" you could call it "List View" or something. :)
Comment 16•17 years ago
|
||
Pete, this bug is about switching to the Sunbird task list (also UnifinderToDo) in Lightning, not the event unifinder above the calendar views (bug 372829).
Comment 17•17 years ago
|
||
(In reply to comment #11) > I wait to get this through UI-review until I spend more time on this. Sven, we'd greatly appreciate this feature for 0.7, so it would be great to see it advance. Christian and I think that even if changes are to come, the unifinder list behaves much better than the current one in lightning (and fixes bug 353791 BTW). But please mind Simon's comment #10 (especially to consolidate the code) and that we are heading for UI string freeze 3rd of september. > If this is the desired way to go, it would save the separate development of the > Lightning todo-list, but would need to check for every reference to the 'Show > completed tasks' checkbox. Yes, this needs to be done; lightning's "Show completed tasks" seems more intuitive to me.
Comment 18•17 years ago
|
||
Comment on attachment 274747 [details] Screenshot of Unifinder ToDo list in Lightning 0.7pre (20070731) As I mentioned earlier I really support the approach of getting the Unifinder ToDo in. Some general comments which don't need to be fixed right now. - It should be possible to display the Calendar Color in form of a box - The context menu should restructured [1] - Hide completed task should be removed - Color coding of tasks not "self explaining" (red, blue, green, grey out) - Grouping (No, Due, Today Tomorrow...) should be added ... ui-r=christian. Thanks for the patch from an ui point of view. [1] http://wiki.mozilla.org/Calendar:Mail_View_Integration#Task_Tree
Attachment #274747 -
Flags: ui-review?(christian.jansen) → ui-review+
Assignee | ||
Comment 19•17 years ago
|
||
This is an updated version of the original patch without any modifications besides the fact that it now cleanly compiles in Lightning. I updated the references to the resources and included a missing dtd file. Apart from the fact that it works, I would like to suggest that instead of adding complexity to the code base we should strive for a consolidation where ever possible. This means that instead of copying from calendar.xul/calendar.js we should move the code to calendar/base (into some new file, e.g. calendar-unifinder-todo.xul/js). This would leave us with a single instance of the code that would be used in Lightning as well as in Sunbird.
Reporter | ||
Comment 20•17 years ago
|
||
Mickey, thank you for 'cleaning' my patch. As usual I am not very used to CVS etc. - but I tried to correct the patch as requested. Furthermore I cleaned up some changes, which are not needed any more (the first patch was for Lightning 0.3.1). I finally even managed the difference between SHOW/HIDE completed tasks (to satisfy Daniel's comment #17), but got errors in error console with the latest UnifinderToDo.js; could somebody verify this, please? I did not have errors with the 0.5 release version of Sunbird, but this one does not set the 'view.showCompleted' attributes. In general I agree, that consolidation would be much better than copying, but I suggest to open another follow-up bug instead. Just think about the SHOW/HIDE difference, this one should be unified first.
Attachment #257517 -
Attachment is obsolete: true
Attachment #277548 -
Flags: review?(michael.buettner)
Assignee | ||
Comment 21•17 years ago
|
||
Comment on attachment 277066 [details] [diff] [review] clean & up2date patch Marking my intermediate patch obsolete since Sven posted a new version.
Attachment #277066 -
Attachment is obsolete: true
Assignee | ||
Comment 22•17 years ago
|
||
Comment on attachment 277548 [details] [diff] [review] Replace ToDo list with UnifinderToDo > In general I agree, that consolidation would be much better than copying, but I > suggest to open another follow-up bug instead. I think there's no reason to let this feature land without being in its final shape. Experience shows that the first step is taken all too willingly but the boring clean-up step gets no further attention. Unfortunately, that's why I need to insist on getting both steps done in a single patch. Furthermore, it's not complicated at all. Please see my previous comment for a suggestion where the shared files could live. All that needs to be done from there is some tweaking of the chrome.manifest (for Lightning) and either #includes or dynamic overlays (for Sunbird). I also get the following exceptions while running this patch (Thunderbird version 2.0.0.7pre (20070817) and Lightning burning edge CVS). Error: aDate has no properties Source File: chrome://calendar/content/calendar-decorated-day-view.xml Line: 75 Error: [Exception... "'[JavaScript Error: "aDate has no properties" {file: "chrome://calendar/content/calendar-decorated-day-view.xml" line: 75}]' when calling method: [calIObserver::onEndBatch]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: file:///C:/mozilla/branch18/build/release/thunderbird/dist/xpi-stage/lightning/js/calUtils.js :: notifyFunc :: line 1077" data: yes] Source File: file:///C:/mozilla/branch18/build/release/thunderbird/dist/xpi-stage/lightning/js/calUtils.js Line: 1080
Attachment #277548 -
Flags: review?(michael.buettner) → review-
Reporter | ||
Comment 23•17 years ago
|
||
Mickey, you are totally right! The report of this bug began more like a 'proof-of-concept' to show, that the Unifinders are easily portable to Lightning, as they exist in Sunbird. I never wanted to go so far to solve this bug on my own, but now it seems I have to go this step. Unfortunately it seems, that I have to establish a working build environment with CVS and all other goodies first, especially to patch 'chrome.manifest' and 'jar.mn' - so, please give me some time. On the other hand I fear, I don't have enough experiences to play around with #includes or moving build files to another location. Sorry again for my ragged work on this, but I will promise improvement!
Assignee | ||
Comment 24•17 years ago
|
||
Sven, since there wasn't any further response during the last week I'm wondering what's the current state of affairs with this issue? Any update on it? If you don't feel comfortable with providing a patch within the remaining 0.7 timeframe I could offer to reassign this bug to myself (and provide a patch my myself, that is). But I don't want to put any pressure on you nor do I want to steal bugs from others. Just take this as a reminder plus a friendly offer... :-)
Reporter | ||
Comment 25•17 years ago
|
||
Mickey, sorry for the delay... It was not very intuitive to get a build environment with MSVC6 behind a firewall... I did not find any build errors and verified the exceptions in the JavaScript Console. I found, that the appeared with your patch for bug 332193. I included the workaround with this new patch. Indeed I don't have plenty of time right now, so please feel free to take this bug ;-) If you can arrange to address your mentioned issues, I would never disagree to loose assignment. I am always happy in providing ideas and leave the 'dirty work' for someone else... Thanks, if you take this bug and push it through review to get it in for 0.7!
Attachment #277548 -
Attachment is obsolete: true
Attachment #279087 -
Flags: review?(michael.buettner)
Assignee | ||
Comment 26•17 years ago
|
||
The core of the patch needs to move the context menu and the xul content from /m/c/sunbird/base/content/calendar.xul to /m/c/base/content/calendar-unifinder-todo.xul (a file that has to be introduced and is intended to contain shared content). Besides that we just need to change some prominent hooks and do some jar.mn magic. What makes this solution particular elegant is the fact that we can wrap the xul content into an overlay that gets applied to lightning as well as to sunbird. We don't need the hassle with employing the preprocessor and #include statements at all. With this approach we can removed a bunch of files: calendar-todo-list.css [lightning\content] calendar-todo-list.xml [lightning\content] todo-list-overlay.xul [lightning\content] todo-list.js [lightning\content] unifinderToDo.js [resources\content] We need to merge some stuff, which goes to base\content: calendar-unifinder-todo.js [base\content] calendar-unifinder-todo.xul [base\content] calendar-unifinder-todo.css [base\themes\*instripe] A particular annoying thorn in my side was the 'Show completed Tasks' vs 'Hide completed task' madness. This gives us the chance to consolidate that as well, what's worth while for the code applies to the UI as well. I decided to take the Sunbird route and keep the 'Hide completed Tasks' checkbox. Moving this to the menu is a story for some other day. The upcoming patch has an impact on lightning.dtd as I'm going to remove the now obsolete strings. I decided to duplicate the command related bits and pieces (6 lines in total). First of all, consolidating the commands for Lightning and Sunbird has a major impact on the hidden window (we could get rid of #includes and take the overlay route as well), but a) this is way to risky considering that we have only one week left to 0.7 RC1 and b) bug 392171 is already filed on that. I also decided not to move the binaries, as this can easily be addressed when moving more files to base/content. At least, I didn't feel particular inspired to do that in this patch as it already grew beyond what I imagined (with respect to its size, that is)...
Assignee: giermann → michael.buettner
Status: ASSIGNED → NEW
Assignee | ||
Comment 27•17 years ago
|
||
This patch should do the trick...
Attachment #279087 -
Attachment is obsolete: true
Attachment #279907 -
Flags: review?(daniel.boelzle)
Attachment #279087 -
Flags: review?(michael.buettner)
Comment 28•17 years ago
|
||
(In reply to comment #26) > The upcoming patch has an impact on lightning.dtd > as I'm going to remove the now obsolete strings. This puts just unnecessary workload on all 24 localization teams. I suggest to defer the string removal until after 0.7 is released.
Assignee | ||
Comment 29•17 years ago
|
||
Comment on attachment 279907 [details] [diff] [review] final patch v1 Asking Christian for UI review since this patch attempts to change the 'Hide completed Tasks' feature (at least for Lightning).
Attachment #279907 -
Flags: ui-review?(christian.jansen)
Assignee | ||
Comment 30•17 years ago
|
||
(In reply to comment #28) > This puts just unnecessary workload on all 24 localization teams. > I suggest to defer the string removal until after 0.7 is released. I'm fine with moving this piece of the patch so some general 'cleanup strings after 0.7 is out of the door' spin-off bug. As a side note, this patch also solves bug 358791 and 360216. So buy one, get another two for free.
Updated•17 years ago
|
Status: NEW → ASSIGNED
Version: Lightning 0.3.1 → unspecified
Comment 31•17 years ago
|
||
From the screenshot, it looks like the patch will include duplicate information on the screen. The agenda shows 'new task', and so does the unifinder. Is that the same new task? If so, won't it be terribly confusing to have the same information on screen twice?
Comment 32•17 years ago
|
||
(In reply to comment #31) Yes, it's the same information. But it's possible to toggle between Agenda only view or Task only view or Agenda + Task view in the sidebar. In addition the Agenda allows to view All items or Events only or Tasks only. The latter is shown in the screenshot. This allows the user to just view the information required (e.g. hiding tasks in the Agenda view). Maybe it's worth to think about the default setup later.
Comment 33•17 years ago
|
||
(In reply to comment #32) > This allows the user to just view the information required (e.g. hiding tasks > in the Agenda view). Maybe it's worth to think about the default setup later. No, we should think about the default now. Otherwise it's not unlikely that it will be ignored for quite some time (because everybody already has set his profile to something he likes, and nobody notices the default anymore) And if there are options that make sense and options that do not make sense (like having duplicate information), I think we should remove the latter options. Just make it work right, instead of having the option to make it work right. I propose that instead of two options (selecting the visibility of the unifinder and selecting the visibility of tasks in the agenda), we link those two options into one UI element. That way, it's no longer possible to select the confusing option.
Comment 34•17 years ago
|
||
(In reply to comment #33) Because the issue raised in #31 - #33 is off topic for this bug I suggest to file a new bug for it. This bug just replaces the minimal Task list in Lightning with the more functional Task list from Sunbird.
Reporter | ||
Comment 35•17 years ago
|
||
(In reply to comment #27) > Created an attachment (id=279907) [details] > final patch v1 > > This patch should do the trick... > Mickey, thanks for your work - primely done. But at least I have two notes: 1. The agenda does not refresh for me, when I toogle 'Hide Completed Tasks' - can you confirm this, or is this a patch/build error, that is "my fault"? 2. I encountered an error on reference to refreshEventTree() with my patch - I guessed, that it was an error in 'UnifinderToDo.js' applied this patch: > diff -u -8 -p -r1.80.2.16 unifinderToDo.js > --- mozilla/calendar/resources/content/unifinderToDo.js 31 Jul 2007 07:30:59 -0000 1.80.2.16 > +++ mozilla/calendar/resources/content/unifinderToDo.js 31 Aug 2007 11:13:30 -0000 > @@ -78,17 +78,17 @@ var unifinderToDoDataSourceObserver = > this.mInBatch = true; > }, > onEndBatch: function() { > this.mInBatch = false; > toDoUnifinderRefresh(); > }, > onLoad: function() { > if (!this.mInBatch) > - refreshEventTree(); > + toDoUnifinderRefresh(); > }, > onAddItem: function(aItem) { > if (aItem instanceof Components.interfaces.calITodo && > !this.mInBatch) > { > toDoUnifinderRefresh(); > } > }, But I do not know, if the call should go to refreshEventTree() or to toDoUnifinderRefresh() instead... In the corresponding Unifinder.js, all calls go to refreshEventTree(), so I assumed that they have to be equal in UnifinderToDo.js too.
Comment 36•17 years ago
|
||
The context menu doesn't work for me. Alternatively pressing DEL in Lightning's Today Pane doesn't delete the todo, but still the selected mail.
Comment 37•17 years ago
|
||
UI Review - The context menu does not work correctly - The "Hide Completed Task" should be move, but this should be fixed in a spinn-off bug. - First impression: UI works as expected, but we should be tested in detail. - As Daniel mentioned the DEL should work as expected - On MAC I had trouble to perform a double click, for crating a new task From an UI-Review perspective I tend to a UI-R=+, because the UI works like in Sunderbird.
Comment 38•17 years ago
|
||
Comment on attachment 279907 [details] [diff] [review] final patch v1 See Comment #36
Attachment #279907 -
Flags: ui-review?(christian.jansen) → ui-review+
Assignee | ||
Comment 39•17 years ago
|
||
Second iteration of the patch with all the above comments addressed. 1) I'm leaving the dtd-file as they are, see comment #28. 2) Regarding the issue that toggling 'Hide completed tasks' doesn't affect the agenda, comment #35. Thanks Sven, nicely spotted. This is fixed in this version of the patch. 3) Again an issue from comment #35. Yes, the call should have read 'toDoUnifinderRefresh()'. Thanks, Sven. 4) Problems with context menu, comment #36. This was the most tricky issue that this new iteration addresses. I made a compile time distinction between Sunbird and Lightning by using #ifdef MOZ_SUNBIRD. The context menu popup needs to be hooked up into the window, which has different id's for Sunbird and Lightning. The #ifdef just made sure we're using the right id's. But the pitfall was that if we're compiling Lightning as an extension for Sunbird (MOZ_CO_PROJECT=calendar), the variable MOZ_SUNBIRD is obviously set to true, even if the resulting extension is to be installed into Thunderbird (which then tried to hook up into window by using the sunbird id, which obviously doesn't work). Fortunately, hooking at the window is not necessary as the popup just needs to be hooked up into the popupset, which has the same id's in Sunbird as well as in Lightning. I'm going to address the 'not functional delete key'-issue with bug 360216 (as I don't want to introduce new features with this patch for the tree itself and the delete key was never hooked up with the unifinder todo).
Attachment #279907 -
Attachment is obsolete: true
Attachment #280334 -
Flags: ui-review+
Attachment #280334 -
Flags: review?(daniel.boelzle)
Attachment #279907 -
Flags: review?(daniel.boelzle)
Comment 40•17 years ago
|
||
(In reply to comment #39) > 1) I'm leaving the dtd-file as they are, see comment #28. Thanks Mickey! Can you please file a followup-bug, which we can tackle for 0.9, once this gets checked in.
Comment 41•17 years ago
|
||
Comment on attachment 280334 [details] [diff] [review] final patch v2 r=dbo (without re-reviewing the moved code portions)
Attachment #280334 -
Flags: review?(daniel.boelzle) → review+
Reporter | ||
Comment 42•17 years ago
|
||
(In reply to comment #39) > Created an attachment (id=280334) [details] Of course, I'm no reviewer, but reading "(without re-reviewing the moved code portions)", I have a short note: +function toDoUnifinderRefresh() +{ [...] + var deck = document.getElementById("view-deck"); + for each (view in deck.childNodes) { + view.showCompleted = !hideCompleted; + } + var selectedDay = deck.selectedPanel.selectedDay; + if (selectedDay) { + deck.selectedPanel.goToDay(selectedDay); + } +} + +function toggleCompletedTasks() { + agendaTreeView.refreshCalendarQuery(); + + for each (view in getViewDeck().childNodes) { + view.showCompleted = !view.showCompleted; + } + + // Refresh the current view + var selectedDay = currentView().selectedDay; + if(selectedDay) { + currentView().goToDay(selectedDay); + } + + toDoUnifinderRefresh(); +} I think you can remove the inversion of the 'showCompleted' flag and the refreshing of the view in 'toggleCompletedTasks', since you call 'toDoUnifinderRefresh', which does it again. So this would reduce to: +function toggleCompletedTasks() { + agendaTreeView.refreshCalendarQuery(); + toDoUnifinderRefresh(); +} Apart from that, excellently done ;-)
Assignee | ||
Comment 43•17 years ago
|
||
Sven, thanks for pointing this out, you're absolutely right. Furthermore, updating the agenda is only necessary for Lightning, that's why I took the liberty to add the necessary check... patch checked in on trunk and MOZILLA_1_8_BRANCH -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Target Milestone: --- → 0.7
Comment 45•17 years ago
|
||
(In reply to comment #40) I filed Bug 396547 to remove the now obsolete entities from lightning.dtd.
Reporter | ||
Comment 46•17 years ago
|
||
VERIFIED with Build 2007-09-23-03-mozilla1.8
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•