Instead of setting the browser.places.importBookmarksHTML pref in the history service (1), we should expose a public property such as nsINavHistoryService.firstRun to indicate bookmarks, history or whatever needs to be imported. 1. http://mxr.mozilla.org/seamonkey/search?string=PREF_BROWSER_IMPORT_BOOKMARKS
Created attachment 291057 [details] [diff] [review] fix pulled out of the patch for 384370
hey dietrich, did this patch bit rot (due to changes from Marco and me) or is it still ready for review?
Created attachment 294772 [details] [diff] [review] v2 unrotted, and updated to take into account the new initialization-related prefs.
My testing scenarios: - new profile, test, restart, test - branch new profile, test, migrate to current, test - a2 new profile, test, migrate to current, test Where "test" is: - confirm bookmarks and history are not empty - confirm default bookmarks - confirm smart bookmarks folder and contents - confirm Library left pane contents
Status: NEW → ASSIGNED
Attachment #294772 - Flags: review?(sspitzer)
could you test also: - delete all profile folder by hand and restart browser - delete places.sqlite by hand and restart browser this could cause a TS regression due to _initplaces changes
about the first point it's "delete all profile folder CONTENTS", not folder itself
Comment on attachment 294772 [details] [diff] [review] v2 r=sspitzer, one nit: + *aImportBookmarks= mImportBookmarks; nit: space before = But, I share some concerns that Marco raised. First, please see bug #406114, which unexpectedly impacted Ts / Txul. Second, see bug #406094, we should confirm that your fix doesn't regress that scenario. Third, see bug #406833, a spin off of bug #406114.
Attachment #294772 - Flags: review?(sspitzer) → review+
fixed in bug 462366.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → WORKSFORME
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.