406833 - recreate the "Smart Bookmarks" folder if both places.sqlite is corrupt (or missing) and bookmarks.html is missing

Status: RESOLVED INVALID

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

recreate the "Smart Bookmarks" folder if both places.sqlite is corrupt (or missing) and bookmarks.html [1] is missing.

this part of the fix for bug #406094 was backed out due to Ts / Txul regressions, see bug #406735

[1] note, we currently recreate places.sqlite from bookmarks.html, but we
should be using bookmarks.postplaces.html, if it exists.  see bug #406114

Also note, at some point we'll be restoring backup from .json instead of .html

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: original patch from marco, but this caused Ts / Txul regressions

Comment 2

[Marco Bonardo [:mak]]

Attachment: create smartbookmarks folder if there is no file to import

this needs a TS test (i don't know how to do that...), Seth or Reed could you try if it's better than previous solution?

this avoid a function call and a service get during normal startup (since we already have the pref service), while if queries have to be created the check on the pref is done twice, but since it will be hwv slow to create queries, should not be so bad.

Comment 3

[Marco Bonardo [:mak]]

ehr wait, this does not work due to the changes to nsBrowserGlue.js (to import bookmarks.postplaces.html), investigating...

Comment 4

[Marco Bonardo [:mak]]

does not work because of Bug 406114, if overwriteBookmark is false we assume that  bookmarks.postplaces.html exists with smart bookmarks, if it does not really exists the createdSmartBookmarks is still True. This cannot be circumvented in nsBrowserGlue.js since there is no way to know if places.sqlite has been replaced.

however with this patch is still possibile to measure the TS regression, even if it does not work actually (will check the pref that will be true instead of false).

Comment 5

[Marco Bonardo [:mak]]

well not totally true that does not work, i've done some testing ( i hope the following is readable)

with the patch
ovrwr  b.html  b.p.html  result
true     y       y       ok
true     y       n       ok
true     n       y       ok
true     n       n       ok
false    y       y       ok
false    y       n       KO
false    n       y       ok
false    n       n       ok

without the patch
ovrwr  b.html  b.p.html  result
true     y       y       ok
true     y       n       ok
true     n       y       KO
true     n       n       KO
false    y       y       ok
false    y       n       KO
false    n       y       ok
false    n       n       KO

Comment 6

[Marco Bonardo [:mak]]

since postplaces will not be imported anymore (waiting for json) we could retry this...
is someone able (and have time) to do a TS test on the patch in comment #2? 
Reed could you take a look at it?
this should only add the time to call a getBoolPref, but don't know how much it will be (someone has an idea of the time involved in getting a pref with the pref service already started?)...

Comment 7

[Marco Bonardo [:mak]]

smart bookmarks forlder does not exists anymore and we are using smartBookmarksVersion config now, marking as invalid

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv