Closed
Bug 394666
Opened 17 years ago
Closed 17 years ago
prefpane height is incorrect when animateFadeIn is true and some other edgecases
Categories
(Firefox :: Settings UI, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3 beta1
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
Attachments
(1 file)
7.20 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.9+
|
Details | Diff | Splinter Review |
The prefpanes display incorrect heights when the animateFadeIn pref is true (Linux as well).
Even though this is not the default configuration I'm going to take a stab at fixing this and at the very least make it better.
spinoff of bug 283697 comment #186
Assignee | ||
Updated•17 years ago
|
Summary: animateFadeIn height is incorrect misbehaves → animateFadeIn height is incorrect
Assignee | ||
Updated•17 years ago
|
Summary: animateFadeIn height is incorrect → prefpane height is incorrect when animateFadeIn is true and some other edgecases
Assignee | ||
Comment 1•17 years ago
|
||
Hey mconnor, this fixes prefWindow animation for Windows / Linux and includes a better fix for bug 349098 in that it doesn't require that the Tabs' prefpane to have flex and makes _content extend to the available height when animation is turned off. I had to use sizeToContent after the first prefpane is loaded in order to get style information but it is only called once so this should be safe. The one thing it doesn't fix is when animation is turn on and the tabs prefpane has wrapping text which has been broken for a long time. I'll look into fixing that as well in a separate bug.
Attachment #279392 -
Flags: review?(mconnor)
Updated•17 years ago
|
Attachment #279392 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 2•17 years ago
|
||
Comment on attachment 279392 [details] [diff] [review]
patch
I'm fine with landing this for M8 (perhaps it isn't too late since there have been several checkins after freeze) or M9.
Attachment #279392 -
Flags: approval1.9?
Updated•17 years ago
|
Attachment #279392 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 3•17 years ago
|
||
Checked in to trunk
Checking in mozilla/toolkit/content/widgets/preferences.xml;
/cvsroot/mozilla/toolkit/content/widgets/preferences.xml,v <-- preferences.xml
new revision: 1.63; previous revision: 1.62
done
Checking in mozilla/browser/components/preferences/tabs.xul;
/cvsroot/mozilla/browser/components/preferences/tabs.xul,v <-- tabs.xul
new revision: 1.17; previous revision: 1.16
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M9
Comment 4•17 years ago
|
||
I think this caused bug 396541
You need to log in
before you can comment on or make changes to this bug.
Description
•