Closed
Bug 394736
Opened 17 years ago
Closed 17 years ago
SeaMonkey Trunk: Choose URl from dropdown Urlbar-History with mouse or arrow-key won't load Site
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a1
People
(Reporter: tobias, Assigned: neil)
References
Details
(Keywords: regression)
Attachments
(2 files)
2.63 KB,
patch
|
ajschult784
:
review+
|
Details | Diff | Splinter Review |
1.63 KB,
patch
|
sdwilsh
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007090302 Mnenhy/0.7.5.20004 SeaMonkey/2.0a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007090302 Mnenhy/0.7.5.20004 SeaMonkey/2.0a1pre
After Neils checkin for Bug 394520 choose (mark) an URI from dropdown History-List in Urlbar with mouse or Arrow-Key will not start to load the Website.
I have to confirm the choosen URI with Enter/Return-Key to load the Site.
Reproducible: Always
Steps to Reproduce:
1. Open Dropdown-History-List with Mouseclick on arrow-button
2. Mark an listed URI with mouse
3. or Arrow-Key and press return
Actual Results:
Choosen URI was listed in Urlbar with Caret behind string, but the Site will not load automatically
Expected Results:
Site load automatically after mark the URI in Dropdown-History-List
When I use autocomplete in Urlbar, the choosen URI was loaded while pressing Enter after mark it in given List.
Reporter | ||
Updated•17 years ago
|
Depends on: 394520
Keywords: regression
Reporter | ||
Updated•17 years ago
|
Version: unspecified → Trunk
Comment 1•17 years ago
|
||
When clicking an entry in the urlbar history, I get the following two errors in error console:
Error: uncaught exception: [Exception... "Component returned failure code: 0x8052000e (NS_ERROR_FILE_IS_LOCKED) [mozIStorageConnection.close]" nsresult: "0x8052000e (NS_ERROR_FILE_IS_LOCKED)" location: "JS frame :: chrome://navigator/content/sessionHistoryUI.js :: createUBHistoryMenu :: line 135" data: no]
Error: uncaught exception: [Exception... "Component returned failure code: 0x8052000e (NS_ERROR_FILE_IS_LOCKED) [mozIStorageConnection.close]" nsresult: "0x8052000e (NS_ERROR_FILE_IS_LOCKED)" location: "JS frame :: chrome://communicator/content/contentAreaClick.js :: addToUrlbarHistory :: line 299" data: no]
I also get the second error only when trying unix-style middle-click-paste on a free area on a web page, which should trigger a load of the pasted URL (and also adding it to urlbarhistory, as it's equivalent to entering this in the urlbar).
Comment 2•17 years ago
|
||
Anyone using Neil's code (in need of support for older builds) needs to add the following check to prevent the: "connection.close is not a function" JavaScript errors:
- connection.close();
+ if (Components.interfaces.mozIStorageService.Number == "{e42f0655-cdc3-47c6-824a-cdb88c731cb9}")
+ connection.close();
Tested with SeaMonkey v1.1.4 and self compiled versions of v1.5 and 2.0a
Assignee | ||
Comment 3•17 years ago
|
||
Just to get things working, until dependencies are fixed.
The pref goop isn't necessary now we're closing things correctly ;-)
Updated•17 years ago
|
Attachment #279504 -
Flags: review?(ajschult) → review+
Assignee | ||
Comment 4•17 years ago
|
||
Attachment #281838 -
Flags: superreview?(jag)
Attachment #281838 -
Flags: review?(comrade693+bmo)
Comment 5•17 years ago
|
||
Comment on attachment 281838 [details] [diff] [review]
Use new API
r=sdwilsh
Glad to see the new API in use already! :)
On a somewhat unrelated note - would you be against me removing support of the Initialize method? It really should be C++ only (and not exposed by COM) in my opinion.
Attachment #281838 -
Flags: review?(comrade693+bmo) → review+
Updated•17 years ago
|
Attachment #281838 -
Flags: superreview?(jag) → superreview+
Assignee | ||
Comment 6•17 years ago
|
||
Fix checked in.
(In reply to comment #5)
>would you be against me removing support of the Initialize method?
Not any more ;-)
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Target Milestone: --- → seamonkey2.0alpha
You need to log in
before you can comment on or make changes to this bug.
Description
•