394798 - Info bubble for just-completed downloads says "Wednesday, December 31, 1969 6:00 PM"

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ed Lee :Mardak]

Attachment: v1

Start time is 0. We don't set startTime other than creating the download, but we don't really need it until we finish anyway... but see bug 394571.

Problem doesn't show up if you close and reopen the dlmgr because we grab the time from the db.

Comment 1

[Ed Lee :Mardak]

Attachment: v1.1

Ugh. Missed the paren. Sorry about that.

Comment 2

[Ryan Flint [:rflint] (ping via IRC for reviews)]

mozilla/toolkit/mozapps/downloads/content/downloads.js 1.86

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

mardak: do you have a good testcase for this?

Comment 4

[Ed Lee :Mardak]

Oops, forgot an important step ;)

1) Open download manager
2) Download a file
3) Click information button

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #4)
> Oops, forgot an important step ;)
> 
> 1) Open download manager
> 2) Download a file
> 3) Click information button

Well, I assumed those steps :-)  What I meant more was, "did this regress?" 

Comment 6

[Ed Lee :Mardak]

(In reply to comment #5)
> "did this regress?" 
Looking at cvs blame on the file, I would assume it "regressed" with bug 388517 (revised UI)

(In reply to comment #4)
> 1) Open download manager
It took me a while to get this bug to reproduce, but now that I realized it was
an issue with dlmgr being open.. This would have been fixed by bug 385734.
sdwilsh: This problem was caused by the d'oh code path not calling
createDownloadItem correctly.

Additionally, bug 393821 on top of bug 385734 solves the real issue, so that we
don't even need the d'oh code path, and we wouldn't have run into this bug to
begin with. ++unified code path. :)

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

I tried reproducing this several different ways, and couldn't, so I'm going to verify this as FIXED; if we see it again, of course, we'll just reopen (or refile).

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007092705 Minefield/3.0a9pre