394832 - Underline too close to text

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Regression from fix for 394109. Now, when I go to the Firefox start page at Google, on Mac I'm seeing the underlines for some of the words (e.g. "Images", "Words", "Groups") touching the text.

Comment 1

[Jesse Ruderman]

I've been seeing "underline touches text" issues for longer than that.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

So have I, but these particular ones appeared just after that checkin.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I think that this is a same bug of bug 380026. I think that this is really gfx/thebes bug. Because the underline position of metrics is wrong.

See bug 380026 comment 3.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

roc: I fixed bug 380026, I hope that you check this bug.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Okay, the issue here is that the calculation of 'ascent' does an integer division and loses precision. Making it a float division fixes the bug.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 280279 [details] [diff] [review]
fix

a1.9=dbaron

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in