396809 - Underline too far from text

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Jesse Ruderman]

Underlines in the default (serif) font on Mac are now two pixels too far away from the text.  I'll attach a screenshot comparing Safari trunk with Firefox trunk.  I'm guessing this is a regression from bug 394832.

This is visible on:
* http://www.squarefree.com/start/
* data:text/html,<u>foo</u>

Comment 1

[Jesse Ruderman]

Attachment: screenshot

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

probably, this is my regression of bug 380026.

the patch for bug 380026 is wrong, I think. I'm thinking another approach for it now...

Comment 3

[Dave Townsend [:mossop]]

This seems very visible on the DOM spec pages, the underline appears to cover the following line of text.

http://www.w3.org/TR/2004/REC-DOM-Level-3-Core-20040407/core.html

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Masayuki, are you going to work on this? If so, can you assign it to yourself?

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I'll work on this, but I'm working for some more risky bugs first.
# This bug is serious issue, but risk of the patch will be low.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Is this still a problem?

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #6)
> Is this still a problem?

I'm trying to fix this in bug 402524.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

this is fixed by bug 402524.

Comment 9

[Dave Townsend [:mossop]]

Attachment: new screenshot

I'm not totally convinced that this is fixed. This is a screenshot from the DOM spec with today's nightly. The underline still seems further away from the text than it should be.

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Dave:

Looks like the font is Courier New. If so, it is correct. The font has very large underline offset. It's font designer's design.