394992 - 0 byte downloads don't actually get created

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Embedding: APIs, defect)

Description

[Ed Lee :Mardak]

From bug 394615, which works around this issue in the UI..

It seems like WebBrowserPersist isn't creating an empty file for 0 byte downloads possibly because it doesn't bother setting data->mStream until it gets an OnDataAvailable.

Perhaps the if block..
if (!data->mStream) // Make the output stream
can be moved to the end of OnStartRequest?? And hopefully it'll create the file and leave it at 0 with no Write calls.

http://mxr.mozilla.org/mozilla/source/embedding/components/webbrowserpersist/src/nsWebBrowserPersist.cpp#830

Comment 1

[Boris Zbarsky [:bzbarsky]]

> can be moved to the end of OnStartRequest?

Seems reasonable.  Want to post a patch?

Comment 2

[Ed Lee :Mardak]

Attachment: screenshot of v1

Here's a picture of it successfully creating a 0byte file.

Testcase would just be to download a 0 byte file similar to litmus testcase for bug 394615.

Comment 3

[Ed Lee :Mardak]

Attachment: v1

Create the out stream data->mStream once at OnStart instead of checking if it should be created each time OnData.

Comment 4

[Ed Lee :Mardak]

biesi: Just making sure I assumed correctly... no need to send status changes from OnStart?

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

I'm actually just going to use the testcase in http://litmus.mozilla.org/show_test.cgi?id=4631 for this, too, since it explicitly asks the tester to check that the file is both saved to disk _and_ correctly appears in the download manager, and so it'll cover this bug as well.

in-litmus+, for that.

Comment 7

[Shawn Wilsher :sdwilsh]

biesi - any update on the review for this?

Comment 8

[Benjamin Smedberg]

Marking a bunch of bugs in the "Embedding: APIs" component INCOMPLETE in preparation to archive that component. If I have done this incorrectly, please reopen the bugs and move them to a more correct component as we don't have "embedding" APIs any more.