395172 - Cannot cancel "bookmark this page" when using ctrl-d or bookmarks menu

Status: RESOLVED INCOMPLETE

(Firefox :: Bookmarks & History, defect)

Description

[Anton van Bohemen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007090504 Firefox/3.0a8pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007090504 Firefox/3.0a8pre

Once you press Ctrl-D or select Bookmarks - Bookmark this page from the menu, you cannot change your mind: the page is automatically starred and bookmarked. The UI at the star button also does not have any cancel options.

Reproducible: Always

Steps to Reproduce:
1. Press Ctrl-D or select Bookmarks - Bookmark this page... from the menu
2. Hit escape or click somewhere in the webpage to close the UI at the Star
3. Open Bookmarks menu
Actual Results:  
The page is starred and bookmarked in the All Bookmarks folder

Expected Results:  
The page should not be starred or bookmarked

Pressing the Star in the address bar twice and the pressing escape does not bookmark the page, in that case it is only starred. It only happens when using the bookmarks menu or the keyboard shortcut.

By the way, the Star UI should probably have a "Close" or "Cancel" button or something, to make it more visible for a user not to add a bookmark. But that may be another bug.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

The "delete" button is effectively a cancel button. See bug 394450.

Comment 2

[[:Aleksej]]

In Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a8pre) Gecko/2007091004 Minefield/3.0a8pre, moving focus to the Delete button and pressing Enter does not destar; pressing Space instead does.

It would be nice if pressing Del key removed the starring if the Name field is empty from the start.

Comment 3

[[:Aleksej]]

The behavior described in comment #2 is still true in
Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9a9pre) Gecko/2007101504 Minefield/3.0a9pre

But now I think the page's title should not be lost forever just because I have pressed a key in the field, and then Enter.

Comment 4

[Shawn Wilsher :sdwilsh]

Bulk closing all UNCONFIRMED bugs dealing with places that haven't had any bug activity in over 120 days, have no votes, and are not enhancement requests.

If you are still experiencing this issue in Firefox 3.0 or later, please re-open the bug with steps to reproduce (if they were not part of the original comment).

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv