395205 - http code doesn't correctly check whether it is resuming

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

nsHttpChannel::OpenCacheEntry checks for the presence of a Range header. However, that header is not set for nsIResumableChannel-initiated range requests at this point - it's only set in SetupTransaction. Therefore, we could open a cache entry even though we should be resuming.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Shawn Wilsher :sdwilsh]

This works correctly for me.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 279909 [details] [diff] [review]
patch

sr=dmose, in case we find a reviewer for this who can't also sr.

Comment 4

[Darin Fisher]

Comment on attachment 279909 [details] [diff] [review]
patch

looks good to me!  r/sr=me

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 279909 [details] [diff] [review]
patch

safe patch to correctly support resuming downloads when the file is (partially or fully) cached

Comment 6

[Shawn Wilsher :sdwilsh]

Comment on attachment 279909 [details] [diff] [review]
patch

This doesn't need approval because it is blocking+.

This can land once the tree opens.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in netwerk/protocol/http/src/nsHttpChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp,v  <--  nsHttpChannel.cpp
new revision: 1.321; previous revision: 1.320
done