Closed Bug 395207 Opened 12 years ago Closed 12 years ago

Download Resume doesn't actually work

Categories

(Toolkit :: Downloads API, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla1.9beta1

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

Details

Attachments

(1 file)

Turns it out it doesn't work, and just grabs it from the cache.  We *do* need the append flag, and a netwerk bug needs to be fixed :)
Flags: blocking-firefox3?
Steps to reproduce:

Start a download.
Pause it.
Clear Cache.
Resume.

You'll get a smaller file than expected when this is broken.
Attached patch v1.0Splinter Review
The UI is totally messed up, but that may be fixed by one of Edward's several patches...
Attachment #279913 - Flags: review?(mconnor)
Target Milestone: --- → Firefox 3 M8
Comment on attachment 279913 [details] [diff] [review]
v1.0

r+a=me, please get this in ASAP
Attachment #279913 - Flags: review?(mconnor)
Attachment #279913 - Flags: review+
Attachment #279913 - Flags: approval1.9+
Just to be clear, this will result in broken downloads until the bug it depends on is resolved (has patch, pending review).
Easier way to test is resume a ftp download. No need to clear the cache.

With this patch, ftp downloads will resume fine though.
Retargeting - didn't make it in on time.
Target Milestone: Firefox 3 M8 → Firefox 3 M9
Checking in toolkit/components/downloads/src/nsDownloadManager.cpp;
new revision: 1.114; previous revision: 1.113
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: blocking-firefox3?
Resolution: --- → FIXED
Looks good with the ISOs from ftp://ftp.redhat.com/pub/redhat/linux/beta/JBEAP4.2.0-Beta1, using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007092705 Minefield/3.0a9pre.

Resuming is fine from FTP; Verified FIXED
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.