396004 - Make mail.tabs.closeButtons=3 actually work

Status: RESOLVED WORKSFORME

(Thunderbird :: Mail Window Front End, defect)

Description

[Phil Ringnalda (:philor)]

Bug 393666 gave us support for mail.tabs.closeButtons=3, for a single close button at the end of the tabstrip, but it doesn't actually work - it calls removeCurrentTab(), which we don't implement, which is the easy part, needs some CSS to not be an invisible button in qute, which should be easy enough, but the part that has me puzzled is that even with a removeCurrentTab method, it doesn't actually work: with two tabs open it looks like it does, since we hide the tabstrip first, but with three you can see it doesn't close, and in the console you see removeTab() choking when it fails to find the tabOwner. I sort of vaguely suspect that means that we're losing track of the current tab on a click on the end-of-strip close button, but I'm not sure where to go to figure that out.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Not enough v.1

The removeCurrentTab method, that's not enough to make it work.

Comment 2

[Phil Ringnalda (:philor)]

And I haven't gotten any more sure where to go.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

On linux it appears we have serious theme issues with mail.tabs.closeButtons=3, but apart from the effectively invisible button on the end of the tab bar, it works great.

Feel free to log a new bug against the theme or re-open this one if you are going to actively work this to closure.  Since the tab pref is not a UI-visible feature, I don't think we otherwise need this bug since the logic problem is resolved.