396562 - Height of the menu bar (File, Edit, View, etc.) is too small (space above menu bar text cut too short)

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Reed Loden [:reed]]

Attachment: comparison screenshot

The height of the menu bar (File, Edit, View, etc.) is too small on trunk as compared to branch (the space above the menu bar is cut short). For what I mean, see the screenshot for a comparison. Most GTK apps look like what Bon Echo has, so this change on trunk is a noticeable change that just looks ugly. I'll attempt to find a regression range for this.

Comment 1

[Reed Loden [:reed]]

Looks like Neil's patch in bug 127244 caused this.

Comment 2

[Alfred Kayser]

This is cross-platform (one of the charmes of XUL...)

Comment 3

[Alfred Kayser]

Attachment: Screenshot of menubar problem in Nautipolis theme in Firefox

This is what happens in all my themes.
According to DOM Inspector the menubar is actually 10px high, but the
containing hbox has height 19px. Can someone explain me why this 'height:0' is
needed? 

See also bug 396565, comment 1:
Starting with the 2007-09-05-02 build, the menubar is not actually tall enough
for the text (or more precisely for the accesskey underlines).  Removing the
height="0" thing that bug 282188 added fixes the problem.

Comment 4

[[e-mail]]

I've put what I believe is the fix in bug 396565; does anyone want to mess around with the dependencies/duplication?

Comment 5

[Reed Loden [:reed]]

Fixed by the patch in bug 396565, afaik...