Closed Bug 396580 Opened 13 years ago Closed 13 years ago

Fix guessSystemTimezone if no TZNAME is set

Categories

(Calendar :: Internal Components, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

Details

Attachments

(2 files)

Quote RFC2445:

   The optional "TZNAME" property is the customary name for the time
   zone. It may be specified multiple times, to allow for specifying
   multiple language variants of the time zone names. This could be used
   for displaying dates.

Currently, guessSystemTimezone expects it to be there and tries to get the value as an ical string. This leads to exceptions in the views.

r=ctalbert as discussed
Attachment #281335 - Flags: review+
Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment on attachment 281335 [details] [diff] [review]
Fix guessSystemTimezone - v1

>-        var standardName = standard.getFirstProperty("TZNAME").valueAsIcalString;
>+        var standardName = standard.getFirstProperty("TZNAME");

Please rename that to standardNameProp or some such, to indicate it's a component in the middle of a whole bunch of strings.
Target Milestone: --- → 0.7
Attached patch Additional patchSplinter Review
Attachment #281472 - Flags: review?(mvl)
Comment on attachment 281472 [details] [diff] [review]
Additional patch

r=mvl
Attachment #281472 - Flags: review?(mvl) → review+
Additional patch checked in
You need to log in before you can comment on or make changes to this bug.