Closed Bug 39667 Opened 25 years ago Closed 25 years ago

[FEATURE] Need to way to get/set LayoutHistoryState for framesets

Categories

(Core :: Layout: Form Controls, defect, P2)

Product:
Core
Component:
Layout: Form Controls
Type:
defect

Tracking

()

Status:
VERIFIED WORKSFORME

People

(Reporter: radha, Assigned: rpotts)

References

(
URL
)

Details

(Whiteboard: [nsbeta2+]Exception Feature)

Attachments

(2 files)

quick fix (non frames cases only)
4.31 KB, patch
Details | Diff | Splinter Review
diff -c, let me know if this works! :)
5.87 KB, patch
Details | Diff | Splinter Review
Need a mechanism to get a handle to nsIHistoryLayoutState when a page goes out of scope and set it when a page is loaded from history
Keywords: nsbeta2
Summary: Need to way to get/set LayoutHistoryState → [FEATURE] Need to way to get/set LayoutHistoryState
nsbeta2 product internal infrastructure. [FEATURE]
Very serious, this is blocking session history from working at all right now. It blocks 35566 (nsbeta2+) which blocks 16806 (nsbeta2+).
Putting on [nsbeta2+] radar for beta2 fix.
Whiteboard: [nsbeta2+]
I'm attaching a quick hack fix that Radha and I came up with. It's just a temporary measure for now to get basic non-framed session history working and close out some of her bugs! :)
Status: NEW → ASSIGNED
Whiteboard: [nsbeta2+] → non-frames (hack) fix in hand [nsbeta2+]
Target Milestone: --- → M16
eric, I'm having trouble applying the diffs. Can you give me a diff -c Thanks, Radha
The temp patch is aparently already checked in, so I guess I don't need to get the review from you that we talked about, thanks Adam. :) This bug is fixed for the basic case, and now only for the more complex frames case needs a solution. Both Radha and my nsbeta2+ bugs that depended on this are unblocked. Since that is why this bug was given nsbeta2+, I'm un-marking nsbeta2+. Giving to Radha to come up with the final solution. Let me know if I can help.
Assignee: pollmann → radha
Status: ASSIGNED → NEW
Summary: [FEATURE] Need to way to get/set LayoutHistoryState → [FEATURE] Need to way to get/set LayoutHistoryState for framesets
Whiteboard: non-frames (hack) fix in hand [nsbeta2+]
Move to M17 (with the other features) ...
Priority: P3 → P2
Target Milestone: M16 → M17
marking nsbeta2+ for real this time
Whiteboard: [nsbeta2+]
Depends on: 36547
Putting on Exception Feature notation
Whiteboard: [nsbeta2+] → [nsbeta2+]Exception Feature
What does this exception feature mean?
It means that we'll hold the beta for this.
Assignee: radha → rpotts
This works for regular pages ie., form value restoration and scrollbar positoins. Should this be an exception feature to make this work in subframes? Anyways, giving to rpotts. We discussed about this last week. New code to be added to PersistlayoutHistoryState() in nsDocShell.cpp
Rick and I just tested this on today's commercial NT build and found that form values do get restored within frames in framesets. Marking worksforme. Adding warp as the test url...
URL: http://warp/
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → WORKSFORME
Marking VERIFED WORKSFORME on: - MacOS9 2000-07-25-11-M17 Commercial Build - Linux6 2000-07-25-08-M17 Commercial Build - Win98 2000-07-25-09-M17 Commercial Build
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: