Closed Bug 36547 Opened 24 years ago Closed 24 years ago

[FEATURE]session history does not handle frames (so no back and forward)

Categories

(Core :: DOM: Navigation, defect, P1)

Product:
Core
Component:
DOM: Navigation
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: doronr, Assigned: rpotts)

References

(
URL
)

Details

(Keywords: regression, top100, Whiteboard: [nsbeta2+][PDT-]) 

On that smoketest page, if you load it in a seperate window, and press the first
link, the frame loads, but there is no back button

this is on m16 2000042008.  marking blocker due to granrose's recommendation
I believe that Radha and Travis are aware of and working on this issue.  Thanks!
Assignee: pollmann → radha
Component: HTMLFrames → History
*** Bug 36763 has been marked as a duplicate of this bug. ***
changed summary to better reflect problem and hopefully ward off dupes.
Summary: No back button option → session history does not handle frames (so no back and forward)
What I see with 2000050820 is that the back button indeed goes back, but it goes 
back to the page that was visited before the frameset. So even if you browse 5 
links deep into documents in a frameset pushing the back button takes you to the 
page you were at before the whole frameset.
Sorry for the spam, forgot to add myself to the CC list while posting comments.
Assignee: radha → valeski
Jud, when the webshell work is done to enable this, you (or whoever does that
work) can re-assign this back to me or radha.  Thanks.

adam
Assignee: valeski → locka
*** Bug 28142 has been marked as a duplicate of this bug. ***
moving leger's comments from Bug 28142 over to here. Still think this should be 
nsbeta2?
Keywords: nsbeta2
Whiteboard: [nsbeta2+][PDT-]
*SPAM* - adding mostfreq keyword to bugs with loads of lease aid this effort by 
adding this keyword to any bugs with more than 15 DUPEs.

Gerv
Keywords: mostfreq
QA Contact: petersen → claudius
Adding demian@iii.co.uk to cc-list.  iii is Stocktrade.co.uk's developer and 
Stocktrade's Sidebar Tab is affected by this bug.
*** Bug 40676 has been marked as a duplicate of this bug. ***
*** Bug 40676 has been marked as a duplicate of this bug. ***
*** Bug 40676 has been marked as a duplicate of this bug. ***
Blocks: 32444
rick, should you take this?
I think this bug needs a ETA, it's pretty vital for nsbeta2

*** Bug 41019 has been marked as a duplicate of this bug. ***
Radha, should this be the tracking bug for all the session history/frames issues
or would bug #39667 be better for that?
Priority: P3 → P1
Target Milestone: --- → M17
Cuurent plan is to shoot for 6/22. Fingers crossed.
Don,
39667 is about restoring form values in subframes. This is regarding making SH 
itself work in subframes.39667 depends on this one.
Blocks: 39667
rick's taking this over.
Assignee: locka → rpotts
*** Bug 42254 has been marked as a duplicate of this bug. ***
*** Bug 42292 has been marked as a duplicate of this bug. ***
*** Bug 42317 has been marked as a duplicate of this bug. ***
*spam* adding myself to cc.

*** Bug 42673 has been marked as a duplicate of this bug. ***
*** Bug 42865 has been marked as a duplicate of this bug. ***
It would be nice if this could be fixed before M17. It makes browsing with M16 
very frustating.
adding some keywords. I noticed the last commentor has a yahoo.com email address
- as I also do. This is indeed a really frustrating bug for people that use
yahoo's web-based email; because it is frame based.
Keywords: regression, top100
*** Bug 43154 has been marked as a duplicate of this bug. ***
*** Bug 43870 has been marked as a duplicate of this bug. ***
Setting platform to ALL, as also a bug on the Mac (see bug 43870, a dup.)
Hardware: PC → All
I have checked in more code today, related to the SH in frameset. Frameset
navigation works now.
The feature is still disabled though. With rick pott's changes regarding
nsiDocShellHistory, I think this
code can be enabled.  I have done some cursory test of messenger and profile
manager. I would like
you all to try this and catch bugs. i'm concerned about the other clients of
docshell like activeX
embeddign and gtkwidget etc... The feature can be enabled by uncommenting the
#define
SH_IN_FRAMES in docshell/base/nsDocShell.h, xpfe/browser/src/nsBrowserInstance.h
and
webshell/src/nsWebShell.cpp. Some of the pages you can visit includes

1) warp.mcom.com, click on QA in the left frame, and go from there.
2) wetnap.mcom.com/frames. Click on "raptor home page" in the left frame and go
from there.

Please try in some of your other favorite frameset pages.

I'll build with leaky enabled and try this out. We have to later  deal with
other users of nsIWebNavigation.

People, cc'ed in this bug, if you have a latest tree, please enable this feature
as descibed above and provide your feedback. Thanks!

*** Bug 44300 has been marked as a duplicate of this bug. ***
Fix  checked in yesterday. please verify
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Go to http://www.lvz.de.

Wait for the frameset to appear then chose a link on the left
navigation bar and visit a few links.

Then try to get back to the front page using the "Back" button - on
my platform (Linux, Build 2000070508) pressing "back" yields nothing...!
(the button can be pushed but nothing happens)

(Prior to the fix I would get transported back to the page BEFORE
the frameset)
It's better, but a few problems still exist (I'm using build 2000070508 on NT).  
To reproduce:

First one:
1. Go to quality URL 
http://www.mozilla.org/quality/browser/bft/bft_frame_index.html
2. Click the "navpanel item 1" link.  This works(updates lower right frame).
3. Click the back button. This works(lower right frame goes back).
4. Click the "navpanel item 1" link.  This works(updates lower right frame).
5. Click the back button. Uh-oh(goes back to the page prior to step 1.

Second one: 
1. Make http://www.mozilla.org/quality/browser/bft/bft_frame_index.html your 
home page using Edit|Preferences.
2. Click the "navpanel item 1" link.  This almost works(updates lower right 
frame, back button "disabled").
3. Click the back button anyway (even though "disabled"). This "works" (lower 
right frame goes back. If the button is disabled, it shouldn't go back, but the 
button shouldn't be disabled, so it should go back).
4. Click the "navpanel item 1" link.  This almost works(updates lower right 
frame, back button "disabled").
5. Back button does nothing at this point. I can't tell if that's because it's 
truly disabled, or because the URL is my home page and can't go back further 
(like the first problem I described.)

Third one (works up through step 5):

1. Go to http://www.AceProgrammer.com/FrameTest1.html
2. Change the right side frame by clicking the link in the left side.
3. Go to the TechServer site using the supplied link.
4. Click the back button.
5. Go to the TechServer site using the supplied link.
6. Click the back button (goes back, but not correctly).

There are reports of problems with the back button in today's linux builds 
only(win32 works fine) see bug # 44558. The back button is supposedly disabled 
when it shouldn't. 
Claudius , can you open a new bug for the problems reported after I marked this 
as Fixed. I would like to keep this in fixed state, since the feature is done.
Summary: session history does not handle frames (so no back and forward) → [FEATURE]session history does not handle frames (so no back and forward)
It's fixed even though Nick's first case shows it broken?
It's fixed because SH now handles frames.  Whether or not there are instances 
when its implementation is broken or functions incorrectly is, I agree, a 
different bug.
ugh, I am most reluctantly VERIFYING this bug. My policy is that for [FEATURE] bugs once the feature is in, the bug gets verified.
Yes we still have bugs, as a matter of fact the original testcase for this bug technically fails, BUT we do have SH for pages with 
frames with the 2000071109 builds. I invite all of those concerned to write new, specific bugs.
Status: RESOLVED → VERIFIED
So... Build 2000071808.

When changed 2 frames Mozilla does not correctly return, when pressed back 
button.

1. Go to www.avp.ee
2. Press any button in left frame.
3. Right frame changes. All is just fine.
4. Now press the first button in the left frame (with a russian flag).
5. Now press the back button in Mozilla.
6. In the right frame we have the page that was when we did step 1, but should 
be page after step 2. 

It was the first bug.

Second one:

1. Go to www.avp.ee
2. Now press the first button in the left frame (with a russian flag). Do not 
get scared about the symbols it's just russian. :)))
3. Press some button in the left frame, but not with the flag.
4. Now press back button.
5. We have returned to step 1, but should to step 3.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
please read my last comments form 7/11. I'm re-closing this bug.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
write NEW bugs. to be thorough you could note the new bug numbers in this bug. Please DO NOT reopen this bug, thanks.
Status: RESOLVED → VERIFIED
Oooops... Is that I described dup of bug 32444?

PS Also see www.hinnavaatlus.ee (it's smth like pricewatch) and play with it.
After some browsing back button does not work anymore...
Related: bug 52001
Blocks: 59387
*** Bug 139190 has been marked as a duplicate of this bug. ***
Mass removing self from CC list.
Now I feel sumb because I have to add back. Sorry for the spam.
I am seeing wacky behavior with frame history in 2002080304 trunk on WinXP.

STEPS TO REPRODUCE:

1) Go to http://www.landlminiatures.com
2) Click on the "Food" button
3) Scroll to the bottom of the "Food" page and click "Next"
4) Click on any food item to get a detailed image
5) Press the "Back" button

RESULT:

Mozilla returns to the homepage.

EXPECTED:

Mozilla should return to the page that was being viewed immediately prior to
viewing the image.

NOTE:

This is not consistent behavior. I am not able to reliable reproduce this.
However, it is frequently occurring.
Ok. To reproduce this, you have to do the following BEFORE taking the steps above:

Load http://www.landlminiatures.com into Mozilla. Then click a link to
http://www.landlminiatures.com so that the link is loaded into the window that
already has this site loaded. Once you do that, history gets hosed completely.
Opened bug 160869.
Component: History: Session → Document Navigation
QA Contact: claudius → docshell
You need to log in before you can comment on or make changes to this bug.