Closed Bug 396743 Opened 17 years ago Closed 17 years ago

Implement Image Viewer (IMG-1)

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: baz, Assigned: clouserw)

References

()

Details

Attachments

(1 file)

Justin -- later on down the road or when you have time can you take a look at the image viewer?
Assignee: nobody → fligtar
*yoink*
Assignee: fligtar → clouserw
Libraries are committed to SVN.  This patch changes the image previewer to use a vanilla install of lightbox, which is an improvement over what we've got.

No one volunteered to review, so I'll just throw it out there and continue to work on making it look more like our mockup.
Attachment #289516 - Flags: review?
Comment on attachment 289516 [details] [diff] [review]
Add slimbox support

Looks virtuous to me.  Tested with fx2.0.0.9 and safari, js on and off.  I find the current locations of the next and previous buttons a bit unfriendly, but I guess you're working on that as part of making it look like the mockup.
Attachment #289516 - Flags: review+
I made changes to the core slimbox code so it looks more like our mockup, and I committed them so those without VPN access could look at them:

http://viewvc.svn.mozilla.org/vc?view=rev&revision=8186

Please feel free to review the code included in that commit.

It's not going to look 100% like our mockup because I talked to Madhava about it and I thought our design wasted a lot of space and encouraged smaller previews with the arrows off to the side like that.  We're coming up with a happy medium in today's meeting. :)
madhava is going to get updated images from Henry
Newest version with less ugly is on staging: 

http://remora.stage.mozilla.com/en-US/firefox/addon/7
Overall looking good.

A few minor (maybe major suggestions):
- On the second image, I noticed that because the background is the same at the border of the round arrow images, that there is artifacting. Is there a way around this? Can we make the buttons transparent?

- I'm finding the constant resizing of the preview window irritating mostly because it means that I have to move my mouse to click on the buttons rather than be guaranteed that I can keep my clicks on the same mouse location. You can shoot me down here but I guess I'm suggesting that we have a fixed preview window size that is calculated based on the largest sized image in the set and then add gray/black borders for stuff that doesn't fix height and width-wise.
Talked about this in our meeting:

> A few minor (maybe major suggestions):
> - On the second image, I noticed that because the background is the same at the
> border of the round arrow images, that there is artifacting. Is there a way
> around this? Can we make the buttons transparent?

Working on it.  Madhava is talking with Henry.
> 
> - I'm finding the constant resizing of the preview window irritating mostly
> because it means that I have to move my mouse to click on the buttons rather
> than be guaranteed that I can keep my clicks on the same mouse location. You
> can shoot me down here but I guess I'm suggesting that we have a fixed preview
> window size that is calculated based on the largest sized image in the set and
> then add gray/black borders for stuff that doesn't fix height and width-wise.
> 

We can file this as a separate enhancement bug, but I don't see it as a blocker here.  One concern for that bug would be that we'd have to load all the images from the server to get the sizes before we'd know the largest size.
(In reply to comment #9)
> > - I'm finding the constant resizing of the preview window irritating (...)
> 
> We can file this as a separate enhancement bug, but I don't see it as a blocker
> here.  One concern for that bug would be that we'd have to load all the images
> from the server to get the sizes before we'd know the largest size.

For bug 373642, we may need to store the image sizes in the database anyway. Morgamic, did you plan on doing that or rather not?
New buttons on staging.  I think this one might be fixed.
They look good, I like them.
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: push-needed
Resolution: --- → FIXED
Keywords: push-needed
Attachment #289516 - Flags: review?
I included the lack of tooltips (using the TITLE attribute) over in bug 409520; this functionality is Verified FIXED (and already on production) :-)
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.