Closed Bug 397012 Opened 13 years ago Closed 13 years ago
menus won't close on second click
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007092022 Minefield/3.0a8pre ID:2007092022 repro: open FF click on an item on the menubar click on it again result: the menu does close briefly and reopens right away. You may have to try a few times, it's not always failing right away. workaround: Clicking outside the menubar closes the menu. regressionrange: works in 20070918_0740_firefox-3.0a8pre.en-US.win32 fails in 20070918_0811_firefox-3.0a8pre.en-US.win32 http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=1190127360&maxdate=1190128259&cvsroot=%2Fcvsroot ->bug 392652
Component: Menus → XP Toolkit/Widgets: Menus
Product: Firefox → Core
QA Contact: menus → xptoolkit.menus
Flags: blocking1.9? → blocking1.9+
Now that popups are being rolled up synchronously (bug 392652), the following happens when clicking the menu label while the menu is open: 1. The popup closes up. 2. The mouse down event fires at the menu, causing the menu to reopen. With asynchronous rollup, step 1 occurs after the mouse down event, so the menu is still open. The fix is essentially to reimplement bug 179567 and temporarily set a flag when closing up the menu.
Comment on attachment 284161 [details] [diff] [review] ignore mouse event when a menu has just closed up r+sr=bzbarsky
Checked in, no test currently as it would require a means of sending native messages to be processed by the widget code.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
I added a null check into nsMenuFrame::ToggleMenuState. Good thing we had a test that found this.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007100911 Minefield/3.0a9pre ID:2007100911 VERIFIED
Status: RESOLVED → VERIFIED
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: xptoolkit.menus → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.