399350 - Clicking menu doesn't work after selecting a command from its popup

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Martijn Wargers (dead)]

To reproduce the bug:
- Click File->Save Page As...
- Click Cancel in that dialog (or ok, whatever you want)
- Click on File again

Expected result:
File menu should open

Actual result:
File menu doesn't open

The file menu does open if you click again.

This regressed since yesterday, so I think a regression from bug 397012.

Comment 1

[Neil Deakin]

Attachment: possible patch

Martijn, I haven't tested this, could you see if this fixes the problem?

Comment 2

[Martijn Wargers (dead)]

I just tried it, it doesn't seem to fix the problem.

Comment 3

[Neil Deakin]

Attachment: try this one

OK, try this patch instead.

Comment 4

[Neil Deakin]

The bug title is a bit misleading, this issue actually occurs when selecting any menu command.

Comment 5

[Martijn Wargers (dead)]

Yeah, that patch works fine.

Indeed, I didn't really play around a lot before, before filing the bug.

Comment 6

[Neil Deakin]

Comment on attachment 284499 [details] [diff] [review]
try this one

This patch resets the recently closed menu state when selecting a command from a menu.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 284499 [details] [diff] [review]
try this one

r+sr=bzbarsky.

Can we add a test for this?

Comment 9

[Luke Iliffe (Harlequin99)]

I can reproduce this behaviour in a new profile by selecting the File - Work Offline menu. After going offline the file menu will not open on first click. Same if you select to go back online and immediately try to click the file menu again. No modal dialogs are present. 

Comment 10

[Neil Deakin]

Attachment: add a check within the menubar tests for this

The test adds a check to ensure that after a menuitem from the edit menu is selected, clicking the edit menu label again still opens the menu.

Comment 11

[Asaf Romano (gone)]

Comment on attachment 284931 [details] [diff] [review]
add a check within the menubar tests for this

r=mano

Comment 13

[WildcatRay]

FYI: http://forums.mozillazine.org/viewtopic.php?p=3104630#3104630

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 284931 [details] [diff] [review]
add a check within the menubar tests for this

a=endgame drivers for M9

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 284499 [details] [diff] [review]
try this one

a=endgame drivers for M9

Comment 16

[Neil Deakin]

Checked in both patches

Comment 17

[Warner Young]

I've found one more case where the menu fails to open, even after this patch.  Should I file a new bug?

The case is: click menu bar to open any menu, for example, Bookmarks.  Click the window's title bar, which will close the menu.  Now click the same menu (Bookmarks) again.  The first click fails, but the second one works.  This is on "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007102904 Minefield/3.0a9pre"

Comment 18

[Martijn Wargers (dead)]

Warner, yes, please file a new bug for that.

Comment 19

[Martijn Wargers (dead)]

Warner filed bug 401627 for it.