Closed
Bug 397116
Opened 18 years ago
Closed 18 years ago
Branch build fails due to missing BeOS libs
Categories
(Thunderbird :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: doug, Assigned: doug)
Details
(Keywords: fixed1.8.1.8)
Attachments
(2 files, 1 obsolete file)
847 bytes,
patch
|
sergei_d
:
review+
mscott
:
approval1.8.1.8+
|
Details | Diff | Splinter Review |
8.46 KB,
application/zip
|
mscott
:
approval1.8.1.8+
|
Details |
User-Agent: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8.1.8pre) Gecko/20070919 BonEcho/2.0.0.8pre
Build Identifier:
Thunderbird build requires linking to tracker and game libs to build under BeOS. Also requires BeOS resource file.
Reproducible: Always
Steps to Reproduce:
1.try to build Thunderbird from 1.8 branch
Actual Results:
Build fails when linking.
Expected Results:
Useable Thunderbird for BeOS
Assignee | ||
Comment 1•18 years ago
|
||
Assignee | ||
Comment 2•18 years ago
|
||
Resource file with appropriate flags and Thunderbird icons. Required for build. Not sure why we didn't have one in the Branch before.
Attachment #281887 -
Flags: review?(sergei_d)
Comment 3•18 years ago
|
||
Comment on attachment 281886 [details] [diff] [review]
BeOS-only change to Makefile.in
r=sergei_d
Attachment #281886 -
Flags: review?(sergei_d) → review+
Comment 4•18 years ago
|
||
About resource file.
For quick look it contains besides logical for mail application mime-type assignments like mailto also those, which surely belong rather to browser:
0)text/html - though, it maybe can be left here
1)application/x-vnd.Be.URL.file
2)application/x-vnd.Be.URL.ftp
3)application/x-vnd.Be.URL.http
4)application/x-vnd.Be.URL.https
next string contains natural for the app mime
5)application/x-vnd.Be.URL.mailto
aswell as
6)application/x-vnd.Be.URL.news
So, i'm unsure if this resource file version is really best choice:)
Comment 5•18 years ago
|
||
addition.
For example, Mail-It supports following mime-types:
0)text/x-email
1)application/x-person (not sure that one is suitable for us, but who knows - it launches Mail-It from click onto "people" file, with people's email as mailto:field)
2)message/rfc822
Also you can look, using "resourcer" application, at default BeMail application, to get more ideas:)
Comment 6•18 years ago
|
||
Doug - here is attempt for more correct resource file. Hope you our our friend from Canada, who worked on Thunderbird, can test it for proper mime support and then create final version
Attachment #281887 -
Attachment is obsolete: true
Attachment #281887 -
Flags: review?(sergei_d)
Comment 7•18 years ago
|
||
Comment on attachment 281887 [details]
BeOS resource file required for building
See comment #4
Attachment #281887 -
Flags: review-
Assignee | ||
Comment 8•18 years ago
|
||
Stupid error on my part, Sergei. This looks much better - I've added Dave to the cc list.
Assignee | ||
Updated•18 years ago
|
Attachment #281935 -
Flags: review?(mrmdls)
Assignee | ||
Updated•18 years ago
|
Attachment #281886 -
Flags: approval1.8.1.8?
Assignee | ||
Updated•18 years ago
|
Attachment #281935 -
Flags: review?(mrmdls) → approval1.8.1.8?
Assignee | ||
Comment 9•18 years ago
|
||
(In reply to comment #6)
> Created an attachment (id=281935) [details]
> possible version for mail resource file
>
> Doug - here is attempt for more correct resource file.
>
Sergei, I've tested this version here. MIME-types we need, no in appropriate types. Good work!
Assignee | ||
Comment 10•18 years ago
|
||
If this is approved, I'll need help checking in. I'm having trouble with check-ins at the moment.
Updated•18 years ago
|
Attachment #281935 -
Flags: approval1.8.1.8? → approval1.8.1.8+
Comment 11•18 years ago
|
||
RCS file: /cvsroot/mozilla/mail/app/Attic/apprunner-beos.rsrc,v
done
Checking in mozilla/mail/app/apprunner-beos.rsrc;
/cvsroot/mozilla/mail/app/Attic/apprunner-beos.rsrc,v <-- apprunner-beos.rsrc
new revision: 1.1.2.1; previous revision: 1.1
done
Now waiting for Makefile.in change approval
Updated•18 years ago
|
Attachment #281886 -
Flags: approval1.8.1.8? → approval1.8.1.8+
Comment 12•18 years ago
|
||
Checking in mozilla/mail/app/Makefile.in;
/cvsroot/mozilla/mail/app/Makefile.in,v <-- Makefile.in
new revision: 1.46.2.8; previous revision: 1.46.2.7
done
You need to log in
before you can comment on or make changes to this bug.
Description
•